linux-kernel - Re: [PATCH v2] drm/nouveau: fix null pointer dereference in nouveau_connector_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c7f963fa69a8bff65c54dbacad4c890ce26f57a4.camel@redhat.com>
Date: Fri, 28 Jun 2024 13:54:51 -0400
From: Lyude Paul <lyude@...hat.com>
To: Ma Ke <make24@...as.ac.cn>, kherbst@...hat.com, dakr@...hat.com, 
	airlied@...il.com, daniel@...ll.ch, airlied@...hat.com, bskeggs@...hat.com
Cc: dri-devel@...ts.freedesktop.org, nouveau@...ts.freedesktop.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] drm/nouveau: fix null pointer dereference in
 nouveau_connector_get_modes

Reviewed-by: Lyude Paul <lyude@...hat.com>

Will push this upstream in just a moment, thanks!

On Thu, 2024-06-27 at 10:27 +0800, Ma Ke wrote:
> In nouveau_connector_get_modes(), the return value of
> drm_mode_duplicate()
> is assigned to mode, which will lead to a possible NULL pointer
> dereference on failure of drm_mode_duplicate(). Add a check to avoid
> npd.
> 
> Fixes: 6ee738610f41 ("drm/nouveau: Add DRM driver for NVIDIA GPUs")
> Signed-off-by: Ma Ke <make24@...as.ac.cn>
> ---
> Changes in v2:
> - modified the patch according to suggestions.
> ---
>  drivers/gpu/drm/nouveau/nouveau_connector.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c
> b/drivers/gpu/drm/nouveau/nouveau_connector.c
> index 856b3ef5edb8..0c71d761d378 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_connector.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_connector.c
> @@ -1001,6 +1001,9 @@ nouveau_connector_get_modes(struct
> drm_connector *connector)
>  		struct drm_display_mode *mode;
>  
>  		mode = drm_mode_duplicate(dev, nv_connector-
> >native_mode);
> +		if (!mode)
> +			return 0;
> +
>  		drm_mode_probed_add(connector, mode);
>  		ret = 1;
>  	}

-- 
Cheers,
 Lyude Paul (she/her)
 Software Engineer at Red Hat