[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <437859E4-AD40-4257-8860-841097AEE51D@redhat.com>
Date: Fri, 28 Jun 2024 20:15:11 +0200
From: Eelco Chaudron <echaudro@...hat.com>
To: Adrian Moreno <amorenoz@...hat.com>
Cc: netdev@...r.kernel.org, aconole@...hat.com, horms@...nel.org,
i.maximets@....org, dev@...nvswitch.org,
Donald Hunter <donald.hunter@...il.com>, Jakub Kicinski <kuba@...nel.org>,
"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
Paolo Abeni <pabeni@...hat.com>, Pravin B Shelar <pshelar@....org>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v6 05/10] net: openvswitch: add psample action
On 28 Jun 2024, at 13:05, Adrian Moreno wrote:
> Add support for a new action: psample.
>
> This action accepts a u32 group id and a variable-length cookie and uses
> the psample multicast group to make the packet available for
> observability.
>
> The maximum length of the user-defined cookie is set to 16, same as
> tc_cookie, to discourage using cookies that will not be offloadable.
>
> Signed-off-by: Adrian Moreno <amorenoz@...hat.com>
I think this patch looks good. After some offline discussion on alignment with the userspace model, we decided to proceed with a psample() specific action.
With that in mind, and considering the additional changes, this patch looks good to me.
Acked-by: Eelco Chaudron echaudro@...hat.com
Cheers,
Eelco
Powered by blists - more mailing lists