lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAP-5=fWT81saq2m+zaXrCsa_V-aqyZvNXDbQ28_wNSBo=-nByw@mail.gmail.com>
Date: Fri, 28 Jun 2024 11:35:32 -0700
From: Ian Rogers <irogers@...gle.com>
To: Abhishek Dubey <adubey@...ux.ibm.com>
Cc: linuxppc-dev@...ts.ozlabs.org, naveen.n.rao@...ux.vnet.ibm.com, 
	mpe@...erman.id.au, npiggin@...il.com, peterz@...radead.org, mingo@...hat.com, 
	namhyung@...nel.org, mark.rutland@....com, alexander.shishkin@...ux.intel.com, 
	jolsa@...nel.org, adrian.hunter@...el.com, linux-perf-users@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf report: Calling available function for stats printing

On Fri, Jun 28, 2024 at 11:32 AM Abhishek Dubey <adubey@...ux.ibm.com> wrote:
>
> For printing dump_trace, just use existing stats_print()
> function.
>
> Signed-off-by: Abhishek Dubey <adubey@...ux.ibm.com>

Reviewed-by: Ian Rogers <irogers@...gle.com>

Thanks,
Ian

> ---
>  tools/perf/builtin-report.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
> index 9718770facb5..6edc0d4ce6fb 100644
> --- a/tools/perf/builtin-report.c
> +++ b/tools/perf/builtin-report.c
> @@ -1089,8 +1089,7 @@ static int __cmd_report(struct report *rep)
>                         perf_session__fprintf_dsos(session, stdout);
>
>                 if (dump_trace) {
> -                       perf_session__fprintf_nr_events(session, stdout);
> -                       evlist__fprintf_nr_events(session->evlist, stdout);
> +                       stats_print(rep);
>                         return 0;
>                 }
>         }
> --
> 2.44.0
>

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ