linux-kernel - Re: [PATCH v3 2/2] interconnect: qcom: Add MSM8953 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f0f09455-5bfd-4dbc-b393-dbef75441e8a@kernel.org>
Date: Fri, 28 Jun 2024 21:39:50 +0300
From: Georgi Djakov <djakov@...nel.org>
To: Barnabás Czémán <barnabas.czeman@...nlining.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
 linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
 Vladimir Lypak <vladimir.lypak@...il.com>,
 Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH v3 2/2] interconnect: qcom: Add MSM8953 driver

Hi Barnabás,

Thank you for the patches!

On 28.06.24 17:01, Barnabás Czémán wrote:
> From: Vladimir Lypak <vladimir.lypak@...il.com>
> 
> Add driver for interconnect busses found in MSM8953 based platforms.
> The topology consists of four NoCs that are partially controlled by a
> RPM processor.
> 
> Note that one of NoCs (System NoC) has a counterpart (System NoC MM)
> that is modelled as child device to avoid resource conflicts, since it
> uses same MMIO space for configuration.
> 
> Signed-off-by: Vladimir Lypak <vladimir.lypak@...il.com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Signed-off-by: Barnabás Czémán <barnabas.czeman@...nlining.org>
> ---
>   drivers/interconnect/qcom/Kconfig   |    9 +
>   drivers/interconnect/qcom/Makefile  |    2 +
>   drivers/interconnect/qcom/msm8953.c | 1321 +++++++++++++++++++++++++++++++++++
>   3 files changed, 1332 insertions(+)
[..]
> +++ b/drivers/interconnect/qcom/msm8953.c
[..]
> +static const struct of_device_id msm8953_noc_of_match[] = {
> +	{ .compatible = "qcom,msm8953-bimc", .data = &msm8953_bimc },
> +	{ .compatible = "qcom,msm8953-pcnoc", .data = &msm8953_pcnoc },
> +	{ .compatible = "qcom,msm8953-snoc", .data = &msm8953_snoc },
> +	{ .compatible = "qcom,msm8953-snoc-mm", .data = &msm8953_snoc_mm },
> +	{ }
> +};
> +
> +static struct platform_driver msm8953_noc_driver = {
> +	.probe = qnoc_probe,
> +	.remove_new = qnoc_remove,
> +	.driver = {
> +		.name = "qnoc-msm8953",
> +		.of_match_table = msm8953_noc_of_match,

Why no .sync_state?

BR,
Georgi