linux-kernel - Re: [PATCH] ASoC: dt-bindings: realtek,rt5645: Convert to dtschema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240628203456.GA170991-robh@kernel.org>
Date: Fri, 28 Jun 2024 14:34:56 -0600
From: Rob Herring <robh@...nel.org>
To: Animesh Agarwal <animeshagarwal28@...il.com>
Cc: Daniel Baluta <daniel.baluta@....com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-sound@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: dt-bindings: realtek,rt5645: Convert to dtschema

On Fri, Jun 21, 2024 at 09:10:27PM +0530, Animesh Agarwal wrote:
> Convert the RT5650/RT5645 audio CODEC bindings to DT schema.
> 
> Signed-off-by: Animesh Agarwal <animeshagarwal28@...il.com>
> Cc: Daniel Baluta <daniel.baluta@....com>
> ---
>  .../bindings/sound/realtek,rt5645.yaml        | 129 ++++++++++++++++++
>  .../devicetree/bindings/sound/rt5645.txt      |  82 -----------
>  2 files changed, 129 insertions(+), 82 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/sound/realtek,rt5645.yaml
>  delete mode 100644 Documentation/devicetree/bindings/sound/rt5645.txt
> 
> diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5645.yaml b/Documentation/devicetree/bindings/sound/realtek,rt5645.yaml
> new file mode 100644
> index 000000000000..d2d97d2bca2e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/realtek,rt5645.yaml
> @@ -0,0 +1,129 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/realtek,rt5645.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: RT5650/RT5645 audio CODEC
> +
> +maintainers:
> +  - Animesh Agarwal <animeshagarwal28@...il.com>
> +
> +description: |
> +  This device supports I2C only.
> +
> +  Pins on the device (for linking into audio routes) for RT5645/RT5650:
> +    * DMIC L1
> +    * DMIC R1
> +    * DMIC L2
> +    * DMIC R2
> +    * IN1P
> +    * IN1N
> +    * IN2P
> +    * IN2N
> +    * Haptic Generator
> +    * HPOL
> +    * HPOR
> +    * LOUTL
> +    * LOUTR
> +    * PDM1L
> +    * PDM1R
> +    * SPOL
> +    * SPOR
> +
> +allOf:
> +  - $ref: dai-common.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +      - realtek,rt5645
> +      - realtek,rt5650
> +
> +  reg:
> +    maxItems: 1
> +
> +  interrupts:
> +    maxItems: 1
> +    description: The CODEC's interrupt output.
> +
> +  avdd-supply:
> +    description: Power supply for AVDD, providing 1.8V.
> +
> +  cpvdd-supply:
> +    description: Power supply for CPVDD, providing 3.5V.
> +
> +  hp-detect-gpios:
> +    description: 
> +      A GPIO spec for the external headphone detect pin. If jd-mode = 0, we
> +      will get the JD status by getting the value of hp-detect-gpios.

       maxItems: 1

> +
> +  cbj-sleeve-gpios:
> +    description:
> +      A GPIO spec to control the external combo jack circuit to tie the
> +      sleeve/ring2 contacts to the ground or floating. It could avoid some
> +      electric noise from the active speaker jacks.

       maxItems: 1

With that,

Reviewed-by: Rob Herring (Arm) <robh@...nel.org>