linux-kernel - Re: [PATCH 3/3] selftests: kselftest: also use strerror() on nolibc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4e02d3d6-935a-4184-b8aa-cbd537633783@linuxfoundation.org>
Date: Fri, 28 Jun 2024 14:56:21 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Thomas Weißschuh <linux@...ssschuh.net>,
 Shuah Khan <shuah@...nel.org>
Cc: Willy Tarreau <w@....eu>, linux-kselftest@...r.kernel.org,
 linux-kernel@...r.kernel.org, Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH 3/3] selftests: kselftest: also use strerror() on nolibc

On 5/27/24 10:11, Thomas Weißschuh wrote:
> Hi Shuah,
> 
> Could you Ack the patch below to kselftest.h?
> 
> Thanks,
> Thomas
> 
> On 2024-04-26 13:08:58+0000, Thomas Weißschuh wrote:
>> nolibc gained an implementation of strerror() recently.
>> Use it and drop the ifdeffery.
>>
>> Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net>
>> ---
>>   tools/testing/selftests/kselftest.h | 8 --------
>>   1 file changed, 8 deletions(-)
>>
>> diff --git a/tools/testing/selftests/kselftest.h b/tools/testing/selftests/kselftest.h
>> index 541bf192e30e..f4bfe98c31e4 100644
>> --- a/tools/testing/selftests/kselftest.h
>> +++ b/tools/testing/selftests/kselftest.h
>> @@ -161,15 +161,7 @@ static inline __printf(1, 2) void ksft_print_msg(const char *msg, ...)
>>   
>>   static inline void ksft_perror(const char *msg)
>>   {
>> -#ifndef NOLIBC
>>   	ksft_print_msg("%s: %s (%d)\n", msg, strerror(errno), errno);
>> -#else
>> -	/*
>> -	 * nolibc doesn't provide strerror() and it seems
>> -	 * inappropriate to add one, just print the errno.
>> -	 */
>> -	ksft_print_msg("%s: %d)\n", msg, errno);
>> -#endif
>>   }
>>   
>>   static inline __printf(1, 2) void ksft_test_result_pass(const char *msg, ...)
>>
>> -- 
>> 2.44.0
>>


Sorry - this git lost in my Inbox.

Acked-by: Shuah Khan <skhan@...uxfoundation.org>

thanks,
-- Shuah