linux-kernel - Re: [PATCH] Fix warning in tegra_fuse_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2etkg2arvsxtjgoxuaks34th5llpe5kn3bakelz7naeghexval@s5up5vt4a5gk>
Date: Fri, 28 Jun 2024 23:27:38 +0200
From: Thierry Reding <thierry.reding@...il.com>
To: sikes@...go.org
Cc: jonathanh@...dia.com, kkartik@...dia.com, rdunlap@...radead.org, 
	frank.li@...o.com, linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fix warning in tegra_fuse_add_lookups

On Fri, Jun 28, 2024 at 10:17:13AM GMT, sikes@...go.org wrote:
> 
> 
> > On Jun 28, 2024, at 8:29 AM, Thierry Reding <thierry.reding@...il.com> wrote:
> > 
> > On Fri, Jun 28, 2024 at 05:18:48PM GMT, Thierry Reding wrote:
> >> From: Thierry Reding <treding@...dia.com>
> >> 
> >> 
> >> On Sun, 16 Jun 2024 00:36:57 -0700, Jason Sikes wrote:
> >>> gcc 14.1.1 warns [-Wcalloc-transposed-args] when sizeof() is
> >>> used in the first, but not the second, of two size_t arguments.
> >>> 
> >>> 
> >> 
> >> Applied, thanks!
> >> 
> >> [1/1] Fix warning in tegra_fuse_add_lookups
> >>      commit: f56da7f4048ff41cb029a715935394f5958a825f
> >> 
> >> Best regards,
> > 
> > Scratch that. Looks like gcc isn't warning correctly here.
> > kmemdup_array() does have "size_t element_size, size_t count", so the
> > existing code is correct.
> > 
> > Thierry
> 
> 
> The order changed in kernel mainline recently (very recently).
> 
> Commit: 0ee14725471cea66e03e3cd4f4c582d759de502c
> Subject: mm/util: Swap kmemdup_array() arguments
> 
> Apologies if you received this as a duplicate message. The previous was sent with HTML, and Vger rightfully rejected it.

That commit seems to take care of the change in fuse-tegra.c already, so
this patch is no longer needed, right?

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)