[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20240628214514.GA258254-robh@kernel.org>
Date: Fri, 28 Jun 2024 15:45:14 -0600
From: Rob Herring <robh@...nel.org>
To: Jan Kiszka <jan.kiszka@...mens.com>
Cc: Nishanth Menon <nm@...com>, Vignesh Raghavendra <vigneshr@...com>,
Tero Kristo <kristo@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
devicetree@...r.kernel.org, Bao Cheng Su <baocheng.su@...mens.com>,
Diogo Ivo <diogo.ivo@...mens.com>
Subject: Re: [PATCH v2 3/4] dt-bindings: soc: ti: am645-system-controller:
add child nodes used by main domain
On Wed, Jun 26, 2024 at 06:42:07AM +0200, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@...mens.com>
>
> Expand bindings to cover both the MCU and the main usage of the AM654
> system controller.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@...mens.com>
> ---
> .../soc/ti/ti,am654-system-controller.yaml | 25 +++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml b/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml
> index e79803e586ca..a03e13cf2677 100644
> --- a/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml
> +++ b/Documentation/devicetree/bindings/soc/ti/ti,am654-system-controller.yaml
> @@ -34,6 +34,31 @@ patternProperties:
> type: object
> $ref: /schemas/phy/ti,phy-gmii-sel.yaml#
>
> + "^mux-controller$":
That's not a pattern, but fixed string. Move to 'properties'. I thought
the tools check this. Maybe it didn't apply to rc1 for the bot and you
didn't test either?
> + type: object
> + ref: /schemas/mux/reg-mux.yaml#
> + description:
> + This is the SERDES lane control mux.
> +
> + "^clock@[0-9a-f]+$":
> + type: object
> + $ref: /schemas/soc/ti/ti,am654-serdes-ctrl.yaml#
> +
> + "^dss-oldi-io-ctrl@[0-9a-f]+$":
> + type: object
> + $ref: /schemas/mfd/syscon.yaml#
> + properties:
> + compatible:
> + items:
> + - const: ti,am654-dss-oldi-io-ctrl
> + - const: syscon
> +
> + "^clock-controller@[0-9a-f]+$":
> + type: object
> + $ref: /schemas/clock/ti,am654-ehrpwm-tbclk.yaml#
> + description:
> + Clock provider for TI EHRPWM nodes.
> +
> required:
> - compatible
> - reg
> --
> 2.43.0
>
Powered by blists - more mailing lists