linux-kernel - Re: [patch V4 05/21] irqchip/gic-v3-its: Provide MSI parent for PCI/MSI[-X]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zn84OIS0zLWASKr2@arm.com>
Date: Fri, 28 Jun 2024 23:24:56 +0100
From: Catalin Marinas <catalin.marinas@....com>
To: Thomas Gleixner <tglx@...utronix.de>
Cc: LKML <linux-kernel@...r.kernel.org>,
	linux-arm-kernel@...ts.infradead.org, linux-pci@...r.kernel.org,
	maz@...nel.org, anna-maria@...utronix.de, shawnguo@...nel.org,
	s.hauer@...gutronix.de, festevam@...il.com, bhelgaas@...gle.com,
	rdunlap@...radead.org, vidyas@...dia.com,
	ilpo.jarvinen@...ux.intel.com, apatel@...tanamicro.com,
	kevin.tian@...el.com, nipun.gupta@....com, den@...inux.co.jp,
	andrew@...n.ch, gregory.clement@...tlin.com,
	sebastian.hesselbarth@...il.com, gregkh@...uxfoundation.org,
	rafael@...nel.org, alex.williamson@...hat.com, will@...nel.org,
	lorenzo.pieralisi@....com, jgg@...lanox.com,
	ammarfaizi2@...weeb.org, robin.murphy@....com,
	lpieralisi@...nel.org, nm@...com, kristo@...nel.org,
	vkoul@...nel.org, okaya@...nel.org, agross@...nel.org,
	andersson@...nel.org, mark.rutland@....com,
	shameerali.kolothum.thodi@...wei.com, yuzenghui@...wei.com,
	shivamurthy.shastri@...utronix.de
Subject: Re: [patch V4 05/21] irqchip/gic-v3-its: Provide MSI parent for
 PCI/MSI[-X]

Hi Thomas,

On Sun, Jun 23, 2024 at 05:18:39PM +0200, Thomas Gleixner wrote:
> From: Thomas Gleixner <tglx@...utronix.de>
> 
> The its_pci_msi_prepare() function from the ITS-PCI/MSI code provides the
> 'global' PCI/MSI domains. Move this function to the ITS-MSI parent code and
> amend the function to use the domain hardware size, which is the MSI[X]
> vector count, for allocating the ITS slots for the PCI device.
> 
> Enable PCI matching in msi_parent_ops and provide the necessary update to
> the ITS specific child domain initialization function so that the prepare
> callback gets invoked on allocations.
> 
> The latter might be optimized to do the allocation right at the point where
> the child domain is initialized, but keep it simple for now.
> 
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> Signed-off-by: Anna-Maria Behnsen <anna-maria@...utronix.de>
> Signed-off-by: Shivamurthy Shastri <shivamurthy.shastri@...utronix.de>
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>

I just noticed guests (under KVM) failing to boot on my TX2 with your
latest branch. I bisected to this patch as the first bad commit.

I'm away this weekend, so won't have time to dive deeper. It looks like
the CPU is stuck in do_idle() (no timer interrupts?). Also sysrq did not
seem able to get the stack trace on the other CPUs. It fails both with a
single or multiple CPUs in the same way place (shortly before mounting
the rootfs and starting user space).

Not sure whether it's related by Red Hat's CI is also reporting boot
failures:

https://lore.kernel.org/r/66859.124062817530400571@us-mta-477.us.mimecast.lan

I'll drop your branch from the arm64 for-kernelci for now and have a
look again on Monday.

-- 
Catalin