linux-kernel - Re: [PATCH] mm/shmem: Fix input and output inconsistencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <63aed837-21ae-4bc3-b327-ad2a005e6e4f@linux.alibaba.com>
Date: Fri, 28 Jun 2024 11:32:19 +0800
From: Baolin Wang <baolin.wang@...ux.alibaba.com>
To: Bang Li <libang.li@...group.com>, hughd@...gle.com,
 akpm@...ux-foundation.org
Cc: david@...hat.com, ryan.roberts@....com, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/shmem: Fix input and output inconsistencies



On 2024/6/28 11:23, Bang Li wrote:
> After the commit 19eaf44954df ("mm: thp: support allocation of
> anonymous multi-size THP"), add mTHP support for anonymous shmem.
> We can configure different policies through the multi-size THP
> sysfs interface for anonymous shmem.
> 
> But when we configure the "advise" policy of
> /sys/kernel/mm/transparent_hugepage/hugepages-xxxkB/shmem_enabled,
> we cannot write the "advise", but write the "madvise", which is
> unreasonable. We should keep the output and input values consistent,
> which is more convenient for users.
> 
> Fixes: 61a57f1b1da9 ("mm: shmem: add multi-size THP sysfs interface for anonymous shmem")
> Signed-off-by: Bang Li <libang.li@...group.com>

Good catch. Sorry for my typo. Thanks.
Reviewed-by: Baolin Wang <baolin.wang@...ux.alibaba.com>

> ---
>   mm/shmem.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/shmem.c b/mm/shmem.c
> index 13d139abe69a..d495c0701a83 100644
> --- a/mm/shmem.c
> +++ b/mm/shmem.c
> @@ -4983,7 +4983,7 @@ static ssize_t thpsize_shmem_enabled_store(struct kobject *kobj,
>   		clear_bit(order, &huge_shmem_orders_madvise);
>   		set_bit(order, &huge_shmem_orders_within_size);
>   		spin_unlock(&huge_shmem_orders_lock);
> -	} else if (sysfs_streq(buf, "madvise")) {
> +	} else if (sysfs_streq(buf, "advise")) {
>   		spin_lock(&huge_shmem_orders_lock);
>   		clear_bit(order, &huge_shmem_orders_always);
>   		clear_bit(order, &huge_shmem_orders_inherit);