linux-kernel - Re: [PATCH v2 2/2] hwmon: add MP5920 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 28 Jun 2024 13:29:38 +0800
From: kernel test robot <lkp@...el.com>
To: Alex Vdovydchenko <keromvp@...il.com>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Sean Anderson <sean.anderson@...ux.dev>,
	Guenter Roeck <linux@...ck-us.net>,
	Jean Delvare <jdelvare@...e.com>, Jonathan Corbet <corbet@....net>,
	Delphine CC Chiu <Delphine_CC_Chiu@...ynn.com>
Cc: oe-kbuild-all@...ts.linux.dev, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-hwmon@...r.kernel.org,
	linux-doc@...r.kernel.org, linux-i2c@...r.kernel.org,
	Alex Vdovydchenko <xzeol@...oo.com>
Subject: Re: [PATCH v2 2/2] hwmon: add MP5920 driver

Hi Alex,

kernel test robot noticed the following build errors:

[auto build test ERROR on groeck-staging/hwmon-next]
[also build test ERROR on next-20240627]
[cannot apply to robh/for-next krzk-dt/for-next linus/master v6.10-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Alex-Vdovydchenko/dt-bindings-hwmon-Add-MPS-mp5920/20240628-021125
base:   https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
patch link:    https://lore.kernel.org/r/20240627090113.391730-3-xzeol%40yahoo.com
patch subject: [PATCH v2 2/2] hwmon: add MP5920 driver
config: loongarch-allmodconfig (https://download.01.org/0day-ci/archive/20240628/202406281339.YzOThRyw-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240628/202406281339.YzOThRyw-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202406281339.YzOThRyw-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

>> drivers/hwmon/pmbus/mp5920.c:26:9: error: 'pages' undeclared here (not in a function); did you mean 'page'?
      26 |         pages = 1,
         |         ^~~~~
         |         page
>> drivers/hwmon/pmbus/mp5920.c:27:9: error: 'format' undeclared here (not in a function)
      27 |         format[PSC_VOLTAGE_IN] = direct,
         |         ^~~~~~
>> drivers/hwmon/pmbus/mp5920.c:32:9: error: 'm' undeclared here (not in a function); did you mean 'tm'?
      32 |         m[PSC_VOLTAGE_IN] = 2266,
         |         ^
         |         tm
>> drivers/hwmon/pmbus/mp5920.c:33:9: error: 'b' undeclared here (not in a function); did you mean 'mb'?
      33 |         b[PSC_VOLTAGE_IN] = 0,
         |         ^
         |         mb
>> drivers/hwmon/pmbus/mp5920.c:34:9: error: 'R' undeclared here (not in a function)
      34 |         R[PSC_VOLTAGE_IN] = -1,
         |         ^
>> drivers/hwmon/pmbus/mp5920.c:44:9: warning: excess elements in struct initializer
      44 |         m[PSC_TEMPERATURE] = 1067,
         |         ^
   drivers/hwmon/pmbus/mp5920.c:44:9: note: (near initialization for 'mp5920_info')
   drivers/hwmon/pmbus/mp5920.c:45:9: warning: excess elements in struct initializer
      45 |         b[PSC_TEMPERATURE] = 20500,
         |         ^
   drivers/hwmon/pmbus/mp5920.c:45:9: note: (near initialization for 'mp5920_info')
   drivers/hwmon/pmbus/mp5920.c:46:9: warning: excess elements in struct initializer
      46 |         R[PSC_TEMPERATURE] = -2,
         |         ^
   drivers/hwmon/pmbus/mp5920.c:46:9: note: (near initialization for 'mp5920_info')
>> drivers/hwmon/pmbus/mp5920.c:47:9: error: 'func' undeclared here (not in a function)
      47 |         func[0] = PMBUS_HAVE_VIN  | PMBUS_HAVE_VOUT |
         |         ^~~~
   drivers/hwmon/pmbus/mp5920.c:47:9: warning: excess elements in struct initializer
   drivers/hwmon/pmbus/mp5920.c:47:9: note: (near initialization for 'mp5920_info')


vim +26 drivers/hwmon/pmbus/mp5920.c

    24	
    25	static struct pmbus_driver_info mp5920_info = {
  > 26		pages = 1,
  > 27		format[PSC_VOLTAGE_IN] = direct,
    28		format[PSC_VOLTAGE_OUT] = direct,
    29		format[PSC_CURRENT_OUT] = direct,
    30		format[PSC_POWER] = direct,
    31		format[PSC_TEMPERATURE] = direct,
  > 32		m[PSC_VOLTAGE_IN] = 2266,
  > 33		b[PSC_VOLTAGE_IN] = 0,
  > 34		R[PSC_VOLTAGE_IN] = -1,
    35		m[PSC_VOLTAGE_OUT] = 2266,
    36		b[PSC_VOLTAGE_OUT] = 0,
    37		R[PSC_VOLTAGE_OUT] = -1,
    38		m[PSC_CURRENT_OUT] = 546,
    39		b[PSC_CURRENT_OUT] = 0,
    40		R[PSC_CURRENT_OUT] = -2,
    41		m[PSC_POWER] = 5840,
    42		b[PSC_POWER] = 0,
    43		R[PSC_POWER] = -3,
  > 44		m[PSC_TEMPERATURE] = 1067,
    45		b[PSC_TEMPERATURE] = 20500,
    46		R[PSC_TEMPERATURE] = -2,
  > 47		func[0] = PMBUS_HAVE_VIN  | PMBUS_HAVE_VOUT |
    48			PMBUS_HAVE_IOUT | PMBUS_HAVE_POUT |
    49			PMBUS_HAVE_TEMP,
    50	};
    51	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki