linux-kernel - Re: [PATCH v3 2/2] dt-bindings: soc: ti: pruss: Add documentation for PA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 28 Jun 2024 01:34:23 -0500
From: Nishanth Menon <nm@...com>
To: MD Danish Anwar <danishanwar@...com>
CC: Suman Anna <s-anna@...com>, Conor Dooley <conor+dt@...nel.org>,
        Krzysztof
 Kozlowski <krzk+dt@...nel.org>,
        Rob Herring <robh@...nel.org>,
        Santosh
 Shilimkar <ssantosh@...nel.org>, <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
        <srk@...com>, Vignesh Raghavendra <vigneshr@...com>,
        Roger Quadros
	<rogerq@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH v3 2/2] dt-bindings: soc: ti: pruss: Add documentation
 for PA_STATS support

On 10:56-20240628, MD Danish Anwar wrote:
> 
> 
> On 27/06/24 8:15 pm, Nishanth Menon wrote:
> > On 21:03-20240625, MD Danish Anwar wrote:
> >> Add documentation for pa-stats node which is syscon regmap for
> >> PA_STATS registers. This will be used to dump statistics maintained by
> >> ICSSG firmware.
> >>
> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> >> Signed-off-by: MD Danish Anwar <danishanwar@...com>
> >> ---
> >>  .../devicetree/bindings/soc/ti/ti,pruss.yaml  | 20 +++++++++++++++++++
> >>  1 file changed, 20 insertions(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
> >> index c402cb2928e8..3cb1471cc6b6 100644
> >> --- a/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
> >> +++ b/Documentation/devicetree/bindings/soc/ti/ti,pruss.yaml
> >> @@ -278,6 +278,26 @@ patternProperties:
> >>  
> >>      additionalProperties: false
> >>  
> >> +  ^pa-stats@[a-f0-9]+$:
> >> +    description: |
> >> +      PA-STATS sub-module represented as a SysCon. PA_STATS is a set of
> >> +      registers where different statistics related to ICSSG, are dumped by
> >> +      ICSSG firmware. This syscon sub-module will help the device to
> >> +      access/read/write those statistics.
> >> +
> >> +    type: object
> >> +
> >> +    additionalProperties: false
> >> +
> >> +    properties:
> >> +      compatible:
> >> +        items:
> >> +          - const: ti,pruss-pa-st
> >> +          - const: syscon
> >> +
> >> +      reg:
> >> +        maxItems: 1
> >> +
> > 
> > Is this a patch in a driver series? I do not see the driver part..
> 
> No Nishant, this is not a part of driver series. This binding patch is
> related to [1] which is merged to net-next. The regmap will not be used
> by drivers/soc/ti driver instead once both binding are in, the driver
> changes will be needed in drivers/net/ethernet/ti/icssg/icssg_prueth.c
> as there is no driver changes needed in drivers/soc/ti, I posted this
> patch as stand alone. Considering this binding and [1] they both go to
> different tree, I decided to get the bindings in first and in next
> kernel cycle when they both are part of mainline linux, I can post the
> driver changes.

This is indicating some strong coupling that is sounding a bit
suspicious. Please add in the full series so that folks can see the
inter dependencies.

> 
> > if this is a memory map, why doesn't bus model work?
> > 
> 
> I am just trying to maintain consistency here. pa-stats sub-module is
> similar to mii-g-rt and mii-rt. I am adding pa-stats in the same way as
> mii-g-rt and mii-rt.
> 
> All these three modules are eventually mapping a memory region so that
> the icssg driver can use them and read / configure registers.

Sounds like mapping a bus is more appropriate? I dont seem to see it
though.

> 
> > 
> >>    interrupt-controller@[a-f0-9]+$:
> >>      description: |
> >>        PRUSS INTC Node. Each PRUSS has a single interrupt controller instance
> >> -- 
> >> 2.34.1
> >>
> > 
> 
> [1] https://lore.kernel.org/all/20240529115225.630535-1-danishanwar@ti.com/
> 
> -- 
> Thanks and Regards,
> Danish

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D