linux-kernel - Re: [PATCH] mm/gup: Use try_grab_page() instead of try_grab

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <53ca3c9c-343a-44fd-b9c9-6c123b3da71d@126.com>
Date: Fri, 28 Jun 2024 14:35:38 +0800
From: Ge Yang <yangge1116@....com>
To: Christoph Hellwig <hch@...radead.org>
Cc: akpm@...ux-foundation.org, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org, stable@...r.kernel.org, 21cnbao@...il.com,
 peterx@...hat.com, baolin.wang@...ux.alibaba.com, liuzixing@...on.cn
Subject: Re: [PATCH] mm/gup: Use try_grab_page() instead of try_grab_folio()
 in gup slow path



在 2024/6/28 14:11, Christoph Hellwig 写道:
> I was complaining that switching from a folio to a page interface
> is a retro-step.  But try_grab_page and try_grab_folio actually
> both take a strut page argument and do similar but different things.
> 
> Yikes!
> 
>> -int __must_check try_grab_page(struct page *page, unsigned int flags)
>> +int __must_check try_grab_page(struct page *page, int refs, unsigned int flags)
> 
> This would now make it a try_grab_pages.  Also please try to avoid
> the overly lone lines here and in the external declaration.

Ok, thanks.