linux-kernel - Re: [PATCH v2 2/2] mmc: sdhci-of-ma35d1: Add Nuvoton MA35D1 SDHCI driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8e633bf9-4891-4e5c-acac-187c7e7249f5@intel.com>
Date: Fri, 28 Jun 2024 09:59:06 +0300
From: Adrian Hunter <adrian.hunter@...el.com>
To: Shan-Chun Hung <shanchun1218@...il.com>, ulf.hansson@...aro.org,
 robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 p.zabel@...gutronix.de, pbrobinson@...il.com, serghox@...il.com,
 mcgrof@...nel.org, prabhakar.mahadev-lad.rj@...renesas.com,
 forbidden405@...look.com, tmaimon77@...il.com, andy.shevchenko@...il.com,
 linux-arm-kernel@...ts.infradead.org, linux-mmc@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: ychuang3@...oton.com, schung@...oton.com
Subject: Re: [PATCH v2 2/2] mmc: sdhci-of-ma35d1: Add Nuvoton MA35D1 SDHCI
 driver

On 28/06/24 09:30, Shan-Chun Hung wrote:
> On 2024/6/27 下午 05:40, Adrian Hunter wrote:
>> On 26/06/24 12:49, Shan-Chun Hung wrote:
>>> +    /* Enable INCR16 and INCR8 */
>> Comment would be more useful if it said what INCR16 and
>> INCR8 are
> 
> I will modify as follows:
> 
> /*
>  * Split data into chunks of 16 or 8 bytes for sending.
>  * Each chunk transfer is guaranteed to be uninterrupted on the bus.
>  */
> 

AFAICT, it relates to AHB bus DMA burst size, so maybe add
that if it is correct.