linux-kernel - Re: [PATCH v2 1/2] dt-bindings: mmc: nuvoton,ma35d1-sdhci: Document MA35D1 SDHCI controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ccf4c88c-50ba-46ad-9af7-b9e0d72f2ec2@kernel.org>
Date: Fri, 28 Jun 2024 09:29:52 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Shan-Chun Hung <shanchun1218@...il.com>, ulf.hansson@...aro.org,
 robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
 adrian.hunter@...el.com, p.zabel@...gutronix.de, pbrobinson@...il.com,
 serghox@...il.com, mcgrof@...nel.org,
 prabhakar.mahadev-lad.rj@...renesas.com, forbidden405@...look.com,
 tmaimon77@...il.com, andy.shevchenko@...il.com,
 linux-arm-kernel@...ts.infradead.org, linux-mmc@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: ychuang3@...oton.com, schung@...oton.com
Subject: Re: [PATCH v2 1/2] dt-bindings: mmc: nuvoton,ma35d1-sdhci: Document
 MA35D1 SDHCI controller

On 26/06/2024 11:48, Shan-Chun Hung wrote:

> +    soc {
> +        #address-cells = <2>;
> +        #size-cells = <2>;
> +        mmc@...90000 {
> +            compatible = "nuvoton,ma35d1-sdhci";
> +            reg = <0x0 0x40190000 0x0 0x2000>;
> +            interrupts = <GIC_SPI 31 IRQ_TYPE_LEVEL_HIGH>;
> +            clocks = <&clk SDH1_GATE>;
> +            pinctrl-names = "default", "state_uhs";
> +            pinctrl-0 = <&pinctrl_sdhci1>;
> +            pinctrl-1 = <&pinctrl_sdhci1_uhs>;
> +            resets = <&sys MA35D1_RESET_SDH1>;
> +            nuvoton,sys = <&sys>;
> +            vqmmc-supply = <&sdhci1_vqmmc_regulator>;
> +            bus-width = <8>;
> +            max-frequency = <200000000>;
> +            status = "disabled";

Again: Drop

<form letter>
This is a friendly reminder during the review process.

It seems my or other reviewer's previous comments were not fully
addressed. Maybe the feedback got lost between the quotes, maybe you
just forgot to apply it. Please go back to the previous discussion and
either implement all requested changes or keep discussing them.

Thank you.
</form letter>


Best regards,
Krzysztof