lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <8d128229-4b4d-44f8-b075-8cb1834636e0@gmail.com>
Date: Fri, 28 Jun 2024 15:30:45 +0800
From: Alex Shi <seakeel@...il.com>
To: alexs@...nel.org, Vitaly Wool <vitaly.wool@...sulko.com>,
 Miaohe Lin <linmiaohe@...wei.com>, Andrew Morton
 <akpm@...ux-foundation.org>, linux-kernel@...r.kernel.org,
 linux-mm@...ck.org, minchan@...nel.org, willy@...radead.org,
 senozhatsky@...omium.org, david@...hat.com, 42.hyeyoo@...il.com
Subject: Re: [PATCH 00/20] mm/zsmalloc: add zpdesc memory descriptor for
 zswap.zpool



On 6/28/24 3:26 PM, Alex Shi wrote:
> 
> On 6/28/24 11:11 AM, alexs@...nel.org wrote:
>> From: Alex Shi <alexs@...nel.org>
>>
>> According to Metthew's plan, the page descriptor will be replace by a 8
>> bytes mem_desc on destination purpose.
>> https://lore.kernel.org/lkml/YvV1KTyzZ+Jrtj9x@casper.infradead.org/
>>
>> Here is a implement on zsmalloc to replace page descriptor by 'zpdesc',
>> which is still overlay on struct page now. but it's a step move forward
>> above destination.
>>
>> To name the struct zpdesc instead of zsdesc, since there are still 3
>> zpools under zswap: zbud, z3fold, zsmalloc for now(z3fold maybe removed
>> soon), and we could easyly extend it to other zswap.zpool in needs.
>>
>> For all zswap.zpools, they are all using single page since often used
>> under memory pressure. So the conversion via folio series helper is
>> better than page's for compound_head check saving.
>>
>> For now, all zpools are using some page struct members, like page.flags
>> for PG_private/PG_locked. and list_head lru, page.mapping for page migration.
>>
>> This patachset could save 123Kbyetes zsmalloc.o size.
> 
> This patchset is based on next/mm-unstable.

Sorry, just double checked, this patchset based on git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm mm-unstable branch. "4b17ce353e02 mm: optimization on page allocation when CMA enabled"

Thanks
Alex
> 
>>
>> Thanks
>> Alex
>>
>> Alex Shi (8):
>>   mm/zsmalloc: add zpdesc memory descriptor for zswap.zpool
>>   mm/zsmalloc: use zpdesc in trylock_zspage/lock_zspage
>>   mm/zsmalloc: convert create_page_chain() and its users to use zpdesc
>>   mm/zsmalloc: rename reset_page to reset_zpdesc and use zpdesc in it
>>   mm/zsmalloc: convert SetZsPageMovable and remove unused funcs
>>   mm/zsmalloc: introduce __zpdesc_clear_movable
>>   mm/zsmalloc: introduce __zpdesc_clear_zsmalloc
>>   mm/zsmalloc: introduce __zpdesc_set_zsmalloc()
>>
>> Hyeonggon Yoo (12):
>>   mm/zsmalloc: convert __zs_map_object/__zs_unmap_object to use zpdesc
>>   mm/zsmalloc: add and use pfn/zpdesc seeking funcs
>>   mm/zsmalloc: convert obj_malloc() to use zpdesc
>>   mm/zsmalloc: convert obj_allocated() and related helpers to use zpdesc
>>   mm/zsmalloc: convert init_zspage() to use zpdesc
>>   mm/zsmalloc: convert obj_to_page() and zs_free() to use zpdesc
>>   mm/zsmalloc: add zpdesc_is_isolated/zpdesc_zone helper for
>>     zs_page_migrate
>>   mm/zsmalloc: convert __free_zspage() to use zdsesc
>>   mm/zsmalloc: convert location_to_obj() to take zpdesc
>>   mm/zsmalloc: convert migrate_zspage() to use zpdesc
>>   mm/zsmalloc: convert get_zspage() to take zpdesc
>>   mm/zsmalloc: convert get/set_first_obj_offset() to take zpdesc
>>
>>  mm/zpdesc.h   | 134 +++++++++++++++
>>  mm/zsmalloc.c | 454 +++++++++++++++++++++++++++-----------------------
>>  2 files changed, 384 insertions(+), 204 deletions(-)
>>  create mode 100644 mm/zpdesc.h
>>

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ