linux-kernel - Re: [PATCH v2 1/2] clk: imx93: Move IMX93_CLK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 28 Jun 2024 09:38:54 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Pengfei Li <pengfei.li_1@....com>, krzk+dt@...nel.org, robh@...nel.org,
 abelvesa@...nel.org, mturquette@...libre.com, sboyd@...nel.org,
 conor+dt@...nel.org, shawnguo@...nel.org, s.hauer@...gutronix.de,
 ping.bai@....com, ye.li@....com, peng.fan@....com, aisheng.dong@....com,
 frank.li@....com
Cc: kernel@...gutronix.de, festevam@...il.com, linux-clk@...r.kernel.org,
 imx@...ts.linux.dev, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] clk: imx93: Move IMX93_CLK_END macro to clk driver

On 27/06/2024 10:24, Pengfei Li wrote:
> IMX93_CLK_END was previously defined in imx93-clock.h to indicate
> the number of clocks, but it is not part of the ABI, so it should
> be moved to clk driver.
> 
> Signed-off-by: Pengfei Li <pengfei.li_1@....com>
> ---
> 
> Notes:
>     Change for v2:
>     - Use pre-processor define to simplify code.
> 
>  drivers/clk/imx/clk-imx93.c | 2 ++
>  1 file changed, 2 insertions(+)

Are you sure this builds fine? If you need to define it here, it means
some part of that unit file already uses the define. If so, you include
the header. If you include the header, you should see fat warning.

Really, people, just build your patches...

Best regards,
Krzysztof