linux-kernel - Re: [PATCH -next] mm: memcg: adjust the warning when seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zn5xBNY-Z4eNTCAL@tiehlicka>
Date: Fri, 28 Jun 2024 10:15:00 +0200
From: Michal Hocko <mhocko@...e.com>
To: xiujianfeng <xiujianfeng@...wei.com>
Cc: hannes@...xchg.org, roman.gushchin@...ux.dev, shakeel.butt@...ux.dev,
	muchun.song@...ux.dev, akpm@...ux-foundation.org,
	cgroups@...r.kernel.org, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] mm: memcg: adjust the warning when seq_buf
 overflows

On Fri 28-06-24 16:09:02, xiujianfeng wrote:
> 
> 
> On 2024/6/28 15:45, Michal Hocko wrote:
> > On Fri 28-06-24 07:23:33, Xiu Jianfeng wrote:
> >> Currently it uses WARN_ON_ONCE() if seq_buf overflows when user reads
> >> memory.stat, the only advantage of WARN_ON_ONCE is that the splat is
> >> so verbose that it gets noticed. And also it panics the system if
> >> panic_on_warn is enabled. It seems like the warning is just an over
> >> reaction and a simple pr_warn should just achieve the similar effect.
> >>
> >> Suggested-by: Michal Hocko <mhocko@...e.com>
> >> Signed-off-by: Xiu Jianfeng <xiujianfeng@...wei.com>
> > 
> > Acked-by: Michal Hocko <mhocko@...e.com>
> > 
> > I would just squash this with other patch removing it from
> > memcg_stat_format. But this is up to you.
> 
> Sorry, I might have misunderstood, if you can squash them, it looks good
> to me, thanks.

Andrew usually can do that even when the patch is in his tree. But as
I've said having 2 patches is ok as well.
-- 
Michal Hocko
SUSE Labs