linux-kernel - RE: [PATCH] watchdog: starfive: Add missing clk_disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 28 Jun 2024 08:50:41 +0000
From: Xingyu Wu <xingyu.wu@...rfivetech.com>
To: Chen Ni <nichen@...as.ac.cn>, "wim@...ux-watchdog.org"
	<wim@...ux-watchdog.org>, "linux@...ck-us.net" <linux@...ck-us.net>
CC: "linux-watchdog@...r.kernel.org" <linux-watchdog@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] watchdog: starfive: Add missing clk_disable_unprepare()

On 28/06/2024 11:35, Chen Ni wrote:

> 
> Add the missing clk_disable_unprepare() before return in
> starfive_wdt_enable_clock().
> 
> Signed-off-by: Chen Ni <nichen@...as.ac.cn>
> ---
>  drivers/watchdog/starfive-wdt.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/starfive-wdt.c b/drivers/watchdog/starfive-wdt.c
> index b4b059883618..19a2620d3d38 100644
> --- a/drivers/watchdog/starfive-wdt.c
> +++ b/drivers/watchdog/starfive-wdt.c
> @@ -152,8 +152,10 @@ static int starfive_wdt_enable_clock(struct starfive_wdt
> *wdt)
>  		return dev_err_probe(wdt->wdd.parent, ret, "failed to enable
> apb clock\n");
> 
>  	ret = clk_prepare_enable(wdt->core_clk);
> -	if (ret)
> +	if (ret) {
> +		clk_disable_unprepare(wdt->apb_clk);
>  		return dev_err_probe(wdt->wdd.parent, ret, "failed to enable
> core clock\n");
> +	}
> 
>  	return 0;
>  }

It looks good. Thanks for your patch.

Reviewed-by: Xingyu Wu <xingyu.wu@...rfivetech.com>

Best regards,
Xingyu Wu