linux-kernel - Re: [PATCH resubmit] rtc: ds1307: Detect oscillator fail on mcp794xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <83e2d171-86b0-4d51-8481-dc5b482b97a3@prolan.hu>
Date: Fri, 28 Jun 2024 10:58:33 +0200
From: Csókás Bence <csokas.bence@...lan.hu>
To: Alexandre Belloni <alexandre.belloni@...tlin.com>
CC: <linux-rtc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	Szentendrei, Tamás <szentendrei.tamas@...lan.hu>
Subject: Re: [PATCH resubmit] rtc: ds1307: Detect oscillator fail on mcp794xx

Hi!

On 6/28/24 00:37, Alexandre Belloni wrote:
> Hello,
> 
> It is not clear to me why your resent this one but not the other one,
> can you elaborate?

It was kind of an unrelated patch, I'll send it after I get this one 
merged. But so far, there hasn't been any movements on this series at all.

> On 21/06/2024 10:05:13+0200, Csókás, Bence wrote:
>> This patch enables the detection of the oscillator failure
>> on mcp794xx chips.
>>
>> Co-developed-by: Szentendrei, Tamás <szentendrei.tamas@...lan.hu>
>> Signed-off-by: Szentendrei, Tamás <szentendrei.tamas@...lan.hu>
>> Signed-off-by: Csókás, Bence <csokas.bence@...lan.hu>

The "other one", I assume, refers to this:

On 6/11/24 09:24, Csókás, Bence wrote:
 > `tm_year` may go up to 299 if the device supports the
 > century bit. Therefore, subtracting may not give us
 > a valid 2-digit number, but modulo does.
 >
 > Co-developed-by: Szentendrei, Tamás <szentendrei.tamas@...lan.hu>
 > Signed-off-by: Szentendrei, Tamás <szentendrei.tamas@...lan.hu>
 > Signed-off-by: Csókás, Bence <csokas.bence@...lan.hu>

And the only thing they had in common is that they were in the same 
file, which my colleague, Tamás, put into one commit in our tree, that I 
split for upstreaming purposes. But really, they are not really related 
or interdependent on one another.

Bence