linux-kernel - Re: [PATCH v2 1/3] RISC-V: pi: Force hidden visibility for all symbol references

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHVXubik-T=dv3hds4VuJFFxen1CRhfintGdOu3JsdAeouuOtg@mail.gmail.com>
Date: Fri, 28 Jun 2024 11:21:33 +0200
From: Alexandre Ghiti <alexghiti@...osinc.com>
To: Conor Dooley <conor.dooley@...rochip.com>
Cc: Jesse Taube <jesse@...osinc.com>, linux-riscv@...ts.infradead.org, 
	Ard Biesheuvel <ardb@...nel.org>, Paul Walmsley <paul.walmsley@...ive.com>, 
	Palmer Dabbelt <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>, 
	Nathan Chancellor <nathan@...nel.org>, Nick Desaulniers <ndesaulniers@...gle.com>, 
	Bill Wendling <morbo@...gle.com>, Justin Stitt <justinstitt@...gle.com>, 
	Masahiro Yamada <masahiroy@...nel.org>, Wende Tan <twd2.me@...il.com>, 
	Christophe JAILLET <christophe.jaillet@...adoo.fr>, Sami Tolvanen <samitolvanen@...gle.com>, 
	Andrew Morton <akpm@...ux-foundation.org>, Baoquan He <bhe@...hat.com>, 
	Chen Jiahao <chenjiahao16@...wei.com>, "Mike Rapoport (IBM)" <rppt@...nel.org>, 
	"Vishal Moola (Oracle)" <vishal.moola@...il.com>, linux-kernel@...r.kernel.org, llvm@...ts.linux.dev
Subject: Re: [PATCH v2 1/3] RISC-V: pi: Force hidden visibility for all symbol references

Hi Jesse,

On Thu, Jun 27, 2024 at 12:35 PM Conor Dooley
<conor.dooley@...rochip.com> wrote:
>
> On Wed, Jun 26, 2024 at 01:16:50PM -0400, Jesse Taube wrote:
> > Eliminate all GOT entries in the .pi section, by forcing hidden
> > visibility for all symbol references, which informs the compiler that
> > such references will be resolved at link time without the need for
> > allocating GOT entries.
> >
> > Include linux/hidden.h in Makefile, like arm64, for the
> > hidden visibility attribute.
> >
> > Signed-off-by: Jesse Taube <jesse@...osinc.com>
>
> Did you forget to add --cover-letter to your format-patch incantation?

I admittedly don't understand all the details but it makes the GOT
entry disappear and arm64 uses it too, so:

Reviewed-by: Alexandre Ghiti <alexghiti@...osinc.com>

Thanks,

Alex