linux-kernel - Re: [PATCH] media: qcom: camss: Remove unused phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <32e23a79-ad3a-465f-97e3-d32cbc75019e@xs4all.nl>
Date: Fri, 28 Jun 2024 12:00:04 +0200
From: Hans Verkuil <hverkuil-cisco@...all.nl>
To: Gjorgji Rosikopulos <quic_grosikop@...cinc.com>, rfoss@...nel.org,
 todor.too@...il.com, bryan.odonoghue@...aro.org, andersson@...nel.org,
 konrad.dybcio@...aro.org, mchehab@...nel.org
Cc: linux-media@...r.kernel.org, linux-arm-msm@...r.kernel.org,
 linux-kernel@...r.kernel.org, laurent.pinchart@...asonboard.com,
 quic_hariramp@...cinc.com
Subject: Re: [PATCH] media: qcom: camss: Remove unused phy_sel variable in
 csid gen2

On 26/06/2024 09:47, Gjorgji Rosikopulos wrote:
> The issue is introduced with:
> 
> [PATCH v4 0/8] Move camss version related defs in to resources

In the pull request I posted today I folded this patch into that 6/8 of the
patch series, rather than having this patch on top.

I forgot to mention that in my PR.

Regards,

	Hans

> 
> Signed-off-by: Gjorgji Rosikopulos <quic_grosikop@...cinc.com>
> ---
>  drivers/media/platform/qcom/camss/camss-csid-gen2.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/media/platform/qcom/camss/camss-csid-gen2.c b/drivers/media/platform/qcom/camss/camss-csid-gen2.c
> index 2d8398a91fc2..e1c757933e27 100644
> --- a/drivers/media/platform/qcom/camss/camss-csid-gen2.c
> +++ b/drivers/media/platform/qcom/camss/camss-csid-gen2.c
> @@ -260,17 +260,12 @@ static void __csid_configure_testgen(struct csid_device *csid, u8 enable, u8 vc)
>  
>  static void __csid_configure_rdi_stream(struct csid_device *csid, u8 enable, u8 vc)
>  {
> -	struct csid_testgen_config *tg = &csid->testgen;
> -	u32 val;
> -	u32 phy_sel = 0;
>  	/* Source pads matching RDI channels on hardware. Pad 1 -> RDI0, Pad 2 -> RDI1, etc. */
>  	struct v4l2_mbus_framefmt *input_format = &csid->fmt[MSM_CSID_PAD_FIRST_SRC + vc];
>  	const struct csid_format_info *format = csid_get_fmt_entry(csid->res->formats->formats,
>  								   csid->res->formats->nformats,
>  								   input_format->code);
> -
> -	if (!tg->enabled)
> -		phy_sel = csid->phy.csiphy_id;
> +	u32 val;
>  
>  	/*
>  	 * DT_ID is a two bit bitfield that is concatenated with