[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <3da4fc7b8ea0d596848d64b8dfaf9d84dac9f657.camel@infradead.org>
Date: Fri, 28 Jun 2024 12:41:24 +0100
From: David Woodhouse <dwmw2@...radead.org>
To: Peter Hilber <peter.hilber@...nsynergy.com>,
linux-kernel@...r.kernel.org, virtualization@...ts.linux.dev,
linux-arm-kernel@...ts.infradead.org, linux-rtc@...r.kernel.org, "Ridoux,
Julien" <ridouxj@...zon.com>, virtio-dev@...ts.linux.dev, "Luu, Ryan"
<rluu@...zon.com>
Cc: "Christopher S. Hall" <christopher.s.hall@...el.com>, Jason Wang
<jasowang@...hat.com>, John Stultz <jstultz@...gle.com>, "Michael S.
Tsirkin" <mst@...hat.com>, netdev@...r.kernel.org, Richard Cochran
<richardcochran@...il.com>, Stephen Boyd <sboyd@...nel.org>, Thomas
Gleixner <tglx@...utronix.de>, Xuan Zhuo <xuanzhuo@...ux.alibaba.com>, Marc
Zyngier <maz@...nel.org>, Mark Rutland <mark.rutland@....com>, Daniel
Lezcano <daniel.lezcano@...aro.org>, Alessandro Zummo
<a.zummo@...ertech.it>, Alexandre Belloni <alexandre.belloni@...tlin.com>
Subject: Re: [RFC PATCH v2] ptp: Add vDSO-style vmclock support
On Fri, 2024-06-28 at 13:33 +0200, Peter Hilber wrote:
>
> >
> > /*
> > * What time is exposed in the time_sec/time_frac_sec fields?
> > */
> > uint8_t time_type;
> > #define VMCLOCK_TIME_UNKNOWN 0 /* Invalid / no time exposed */
> > #define VMCLOCK_TIME_UTC 1 /* Since 1970-01-01 00:00:00z */
> > #define VMCLOCK_TIME_TAI 2 /* Since 1970-01-01 00:00:00z */
> > #define VMCLOCK_TIME_MONOTONIC 3 /* Since undefined epoch */
> >
> > /* Bit shift for counter_period_frac_sec and its error rate */
> > uint8_t counter_period_shift;
> >
> > /*
> > * Unlike in NTP, this can indicate a leap second in the past. This
> > * is needed to allow guests to derive an imprecise clock with
> > * smeared leap seconds for themselves, as some modes of smearing
> > * need the adjustments to continue even after the moment at which
> > * the leap second should have occurred.
> > */
> > int8_t leapsecond_direction;
> > uint64_t leapsecond_tai_sec; /* Since 1970-01-01 00:00:00z */
> >
> > /*
> > * Paired values of counter and UTC at a given point in time.
> > */
> > uint64_t counter_value;
> > uint64_t time_sec; /* Since 1970-01-01 00:00:00z */
>
> Nitpick: The comment is not valid any more for TIME_MONOTONIC.
Ah yes, I "moved" that comment up to the UTC/TAI time_type values, but
neglected to actually delete it from here. Fixed; thanks.
Download attachment "smime.p7s" of type "application/pkcs7-signature" (5965 bytes)
Powered by blists - more mailing lists