linux-kernel - Re: [PATCH V4 1/2] cgroup/rstat: Helper functions for locking expose trylock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b637705e-6a7c-4329-9109-50e9f568e64c@kernel.org>
Date: Fri, 28 Jun 2024 14:13:34 +0200
From: Jesper Dangaard Brouer <hawk@...nel.org>
To: Waiman Long <longman@...hat.com>, tj@...nel.org, cgroups@...r.kernel.org,
 yosryahmed@...gle.com, shakeel.butt@...ux.dev
Cc: hannes@...xchg.org, lizefan.x@...edance.com, kernel-team@...udflare.com,
 linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V4 1/2] cgroup/rstat: Helper functions for locking expose
 trylock



On 28/06/2024 00.22, Waiman Long wrote:
> 
> On 6/27/24 17:18, Jesper Dangaard Brouer wrote:
[...]
>>
> Will it be cleaner to add a "bool *flushed" output parameter to 
> __cgroup_rstat_lock() so that the caller can respond differently whether 
> the flushed flag is set or not? In that way, you don't need to expose a 
> separate trylock() API. Also your commit log is empty.
> 

Dropping this API in V5 anyway.
But I do think it is more natural to follow the 'trylock' API as this is
something that people have seen before.

--Jesper