linux-kernel - Re: [PATCH] iommu: Remove iommu_sva_unbind

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fbede9a0-cfbc-4782-99c1-803f611c28b1@linux.intel.com>
Date: Fri, 28 Jun 2024 20:33:01 +0800
From: Baolu Lu <baolu.lu@...ux.intel.com>
To: Mark-PK Tsai <mark-pk.tsai@...iatek.com>, Joerg Roedel <joro@...tes.org>,
 Will Deacon <will@...nel.org>, Robin Murphy <robin.murphy@....com>,
 Matthias Brugger <matthias.bgg@...il.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Cc: baolu.lu@...ux.intel.com, yj.chiang@...iatek.com, iommu@...ts.linux.dev,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH] iommu: Remove iommu_sva_unbind_gpasid

On 2024/6/28 19:30, Mark-PK Tsai wrote:
> This is a left over of commit 0c9f17877891
> ("iommu: Remove guest pasid related interfaces and definitions")
> 
> Signed-off-by: Mark-PK Tsai <mark-pk.tsai@...iatek.com>
> ---
>   include/linux/iommu.h | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/include/linux/iommu.h b/include/linux/iommu.h
> index 17b3f36ad843..225403cfe614 100644
> --- a/include/linux/iommu.h
> +++ b/include/linux/iommu.h
> @@ -785,8 +785,6 @@ extern int iommu_attach_device(struct iommu_domain *domain,
>   			       struct device *dev);
>   extern void iommu_detach_device(struct iommu_domain *domain,
>   				struct device *dev);
> -extern int iommu_sva_unbind_gpasid(struct iommu_domain *domain,
> -				   struct device *dev, ioasid_t pasid);

Not sure why this still remains there. But it seems not alone.

$ git grep iommu_sva_unbind_gpasid
Documentation/userspace-api/iommu.rst:  int 
iommu_sva_unbind_gpasid(struct iommu_domain *domain,
include/linux/iommu.h:extern int iommu_sva_unbind_gpasid(struct 
iommu_domain *domain,

I believe the document should also be removed.

>   extern struct iommu_domain *iommu_get_domain_for_dev(struct device *dev);
>   extern struct iommu_domain *iommu_get_dma_domain(struct device *dev);
>   extern int iommu_map(struct iommu_domain *domain, unsigned long iova,

Best regards,
baolu