linux-kernel - Re: [PATCH v2 net-next 3/3] net: phy: aquantia: add support for aqr115c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <92078d5d-3b10-4651-a42b-4b2ffd23daca@lunn.ch>
Date: Fri, 28 Jun 2024 16:09:01 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Bartosz Golaszewski <brgl@...ev.pl>
Cc: Daniel Golle <daniel@...rotopia.org>,
	Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S . Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH v2 net-next 3/3] net: phy: aquantia: add support for
 aqr115c

> Not sure what to do, should I still be adding a new mode here or is it
> fine to just explain in the commit message that this really is
> "2500Base-X-sans-in-band-signalling" and keep the code as is? Or maybe
> some quirk disallowing `managed = "in-band-status"`?

Yes, please do make it clear in the commit message. It is good to have
a full commit message explaining all the messy details to help the
next person who needs to modify this code, or has the same issue with
another vendor specific glue driver for stmmac, etc.

	Andrew