linux-kernel - Re: [PATCH v3 5/8] perf test: Add landlock workload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 28 Jun 2024 11:50:34 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Howard Chu <howardchu95@...il.com>
Cc: adrian.hunter@...el.com, irogers@...gle.com, jolsa@...nel.org,
	kan.liang@...ux.intel.com, namhyung@...nel.org,
	linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
	Arnaldo Carvalho de Melo <acme@...hat.com>
Subject: Re: [PATCH v3 5/8] perf test: Add landlock workload

On Fri, Jun 28, 2024 at 11:44:22AM -0300, Arnaldo Carvalho de Melo wrote:
> On Tue, Jun 25, 2024 at 02:13:42AM +0800, Howard Chu wrote:
> > We'll use it to add a regression test for the BTF augmentation of enum
> > arguments for tracepoints in 'perf trace':
<SNIP>
> I'm not being able to apply this specific patch:
> 
> ⬢[acme@...lbox perf-tools-next]$ b4 am -ctsl --cc-trailers 20240624181345.124764-1-howardchu95@...il.com
> Grabbing thread from lore.kernel.org/all/20240624181345.124764-1-howardchu95@...il.com/t.mbox.gz
> Checking for newer revisions

<SNIP>

> I'm checking what is this, perhaps I'm using a more recent
> perf-tools-next/perf-tools-next with changes to that
> tools/perf/tests/workloads/Build file...
> 
> ⬢[acme@...lbox perf-tools-next]$ git log --oneline -5 tools/perf/tests/workloads/Build
> 1dad99af1a8211e2 perf test: Make tests its own library
> 3dfc01fe9d12a1e8 perf test: Add 'datasym' test workload
> a104f0ea99d846df perf test: Add 'brstack' test workload
> 39281709a6e2301a perf test: Add 'sqrtloop' test workload
> 41522f7442905814 perf test: Add 'leafloop' test workload
> ⬢[acme@...lbox perf-tools-next]$ 
> 
> Yeah, we need to rebase on top of what we have in
> perf-tools-next/perf-tools-next, probably something minor.

So lets get just this patch and try manually:

⬢[acme@...lbox perf-tools-next]$ b4 am -P5 -ctsl --cc-trailers 20240624181345.124764-1-howardchu95@...il.com
Grabbing thread from lore.kernel.org/all/20240624181345.124764-1-howardchu95@...il.com/t.mbox.gz
Checking for newer revisions
Grabbing search results from lore.kernel.org
Nothing matching that query.
Analyzing 11 messages in the thread
Checking attestation on all messages, may take a moment...
---
  ✓ [PATCH v3 5/8] perf test: Add landlock workload
    + Link: https://lore.kernel.org/r/20240624181345.124764-6-howardchu95@gmail.com
  ---
  ✓ Signed: DKIM/gmail.com
---
Total patches: 1 (cherrypicked: 5)
---
Cover: ./v3_20240625_howardchu95_perf_trace_augment_enum_arguments_with_btf.cover
 Link: https://lore.kernel.org/r/20240624181345.124764-1-howardchu95@gmail.com
 Base: not specified
       git am ./v3_20240625_howardchu95_perf_trace_augment_enum_arguments_with_btf.mbx
⬢[acme@...lbox perf-tools-next]$ patch -p1 < ./v3_20240625_howardchu95_perf_trace_augment_enum_arguments_with_btf.mbx
patching file tools/perf/tests/builtin-test.c
patching file tools/perf/tests/tests.h
patching file tools/perf/tests/workloads/Build
Hunk #1 FAILED at 6.
1 out of 1 hunk FAILED -- saving rejects to file tools/perf/tests/workloads/Build.rej
patching file tools/perf/tests/workloads/landlock.c
⬢[acme@...lbox perf-tools-next]$

1 out of 1 hunk FAILED -- saving rejects to file tools/perf/tests/workloads/Build.rej
patching file tools/perf/tests/workloads/landlock.c
⬢[acme@...lbox perf-tools-next]$ cat tools/perf/tests/workloads/Build.rej
--- tools/perf/tests/workloads/Build
+++ tools/perf/tests/workloads/Build
@@ -6,6 +6,7 @@ perf-y += leafloop.o
 perf-y += sqrtloop.o
 perf-y += brstack.o
 perf-y += datasym.o
+perf-y += landlock.o
 
 CFLAGS_sqrtloop.o         = -g -O0 -fno-inline -U_FORTIFY_SOURCE
 CFLAGS_leafloop.o         = -g -O0 -fno-inline -fno-omit-frame-pointer -U_FORTIFY_SOURCE
⬢[acme@...lbox perf-tools-next]$ 

So just that '+perf-y += landlock.o' line that needs to become
'+perf-test-y += landlock.o'.

See the updated patch attached.

- Arnaldo



Content of type "text/plain" skipped