linux-kernel - Re: [patch V4 05/21] irqchip/gic-v3-its: Provide MSI parent for PCI/MSI[-X]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <86frswhzsx.wl-maz@kernel.org>
Date: Sat, 29 Jun 2024 10:18:54 +0100
From: Marc Zyngier <maz@...nel.org>
To: Catalin Marinas <catalin.marinas@....com>
Cc: Thomas Gleixner <tglx@...utronix.de>,
	LKML <linux-kernel@...r.kernel.org>,
	linux-arm-kernel@...ts.infradead.org,
	linux-pci@...r.kernel.org,
	anna-maria@...utronix.de,
	shawnguo@...nel.org,
	s.hauer@...gutronix.de,
	festevam@...il.com,
	bhelgaas@...gle.com,
	rdunlap@...radead.org,
	vidyas@...dia.com,
	ilpo.jarvinen@...ux.intel.com,
	apatel@...tanamicro.com,
	kevin.tian@...el.com,
	nipun.gupta@....com,
	den@...inux.co.jp,
	andrew@...n.ch,
	gregory.clement@...tlin.com,
	sebastian.hesselbarth@...il.com,
	gregkh@...uxfoundation.org,
	rafael@...nel.org,
	alex.williamson@...hat.com,
	will@...nel.org,
	lorenzo.pieralisi@....com,
	jgg@...lanox.com,
	ammarfaizi2@...weeb.org,
	robin.murphy@....com,
	lpieralisi@...nel.org,
	nm@...com,
	kristo@...nel.org,
	vkoul@...nel.org,
	okaya@...nel.org,
	agross@...nel.org,
	andersson@...nel.org,
	mark.rutland@....com,
	shameerali.kolothum.thodi@...wei.com,
	yuzenghui@...wei.com,
	shivamurthy.shastri@...utronix.de
Subject: Re: [patch V4 05/21] irqchip/gic-v3-its: Provide MSI parent for PCI/MSI[-X]

On Fri, 28 Jun 2024 23:24:56 +0100,
Catalin Marinas <catalin.marinas@....com> wrote:
> 
> Hi Thomas,
> 
> On Sun, Jun 23, 2024 at 05:18:39PM +0200, Thomas Gleixner wrote:
> > From: Thomas Gleixner <tglx@...utronix.de>
> > 
> > The its_pci_msi_prepare() function from the ITS-PCI/MSI code provides the
> > 'global' PCI/MSI domains. Move this function to the ITS-MSI parent code and
> > amend the function to use the domain hardware size, which is the MSI[X]
> > vector count, for allocating the ITS slots for the PCI device.
> > 
> > Enable PCI matching in msi_parent_ops and provide the necessary update to
> > the ITS specific child domain initialization function so that the prepare
> > callback gets invoked on allocations.
> > 
> > The latter might be optimized to do the allocation right at the point where
> > the child domain is initialized, but keep it simple for now.
> > 
> > Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> > Signed-off-by: Anna-Maria Behnsen <anna-maria@...utronix.de>
> > Signed-off-by: Shivamurthy Shastri <shivamurthy.shastri@...utronix.de>
> > Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> 
> I just noticed guests (under KVM) failing to boot on my TX2 with your
> latest branch. I bisected to this patch as the first bad commit.

Reproduced here on a different host (M1), so this is not specific to
TX2 (which would have been odd since KVM emulates the ITS entirely).

I'll start digging.

	M.

-- 
Without deviation from the norm, progress is not possible.