linux-kernel - Re: [PATCH 2/2] arm64: dts: qcom: Add device tree for ASUS Vivobook S 15

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0c47c5fa-5fe2-4675-8eb9-9707f044ce90@linaro.org>
Date: Sat, 29 Jun 2024 14:56:40 +0200
From: Konrad Dybcio <konrad.dybcio@...aro.org>
To: wuxilin123@...il.com, Bjorn Andersson <andersson@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, Abel Vesa <abel.vesa@...aro.org>,
 Johan Hovold <johan+linaro@...nel.org>
Subject: Re: [PATCH 2/2] arm64: dts: qcom: Add device tree for ASUS Vivobook S
 15

On 28.06.2024 1:30 PM, Xilin Wu via B4 Relay wrote:
> From: Xilin Wu <wuxilin123@...il.com>
> 
> ASUS Vivobook S 15 is a laptop based on the Qualcomm Snapdragon X Elite
> SoC (X1E78100).
> 
> Add the device tree for the laptop with support for the following features:
> 
> - CPU frequency scaling up to 3.4GHz
> - NVMe storage on PCIe 6a (capable of Gen4x4, currently limited to Gen4x2)
> - Keyboard and touchpad
> - WCN7850 Wi-Fi
> - Two Type-C ports on the left side (USB3 only in one orientation)
> - internal eDP display
> - ADSP and CDSP remoteprocs
> 
> Further details could be found in the cover letter.
> 
> Signed-off-by: Xilin Wu <wuxilin123@...il.com>
> ---

[...]

> +	pmic-glink {
> +		compatible = "qcom,x1e80100-pmic-glink",
> +			     "qcom,sm8550-pmic-glink",
> +			     "qcom,pmic-glink";
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		orientation-gpios = <&tlmm 121 GPIO_ACTIVE_HIGH>,
> +				    <&tlmm 123 GPIO_ACTIVE_HIGH>;

#address-/size-cells usually go at the end

> +
> +		connector@0 {

Could you add a comment detailing which port is which (like in x1e80100-crd.dts)?

> +		pinctrl-names = "default";
> +		pinctrl-0 = <&nvme_reg_en>;

property-n
property-names

[...]

> +
> +	ports {
> +		port@1 {
> +			reg = <1>;

Please separate properties with subnodes with a newline

[...]

> +
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pcie6a_default>;

property-n
property-names

Looks good otherwise!

Konrad