linux-kernel - RE: [PATCH V3 1/3] pinctrl: ti: iodelay: Use scope based of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sat, 29 Jun 2024 01:32:15 +0000
From: Peng Fan <peng.fan@....com>
To: Uwe Kleine-König <u.kleine-koenig@...libre.com>, "Peng
 Fan (OSS)" <peng.fan@....nxp.com>
CC: "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
	"dan.carpenter@...aro.org" <dan.carpenter@...aro.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, Aisheng Dong <aisheng.dong@....com>,
	"festevam@...il.com" <festevam@...il.com>, "shawnguo@...nel.org"
	<shawnguo@...nel.org>, "kernel@...gutronix.de" <kernel@...gutronix.de>
Subject: RE: [PATCH V3 1/3] pinctrl: ti: iodelay: Use scope based
 of_node_put() cleanups

> Subject: Re: [PATCH V3 1/3] pinctrl: ti: iodelay: Use scope based
> of_node_put() cleanups
> 
> Hello Peng,
> 
> On Thu, Jun 27, 2024 at 09:17:19PM +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@....com>
> >
> > Use scope based of_node_put() cleanup to simplify code.
> >
> > Signed-off-by: Peng Fan <peng.fan@....com>
> > ---
> >  drivers/pinctrl/ti/pinctrl-ti-iodelay.c | 43
> > +++++++++----------------
> >  1 file changed, 15 insertions(+), 28 deletions(-)
> >
> > diff --git a/drivers/pinctrl/ti/pinctrl-ti-iodelay.c
> > b/drivers/pinctrl/ti/pinctrl-ti-iodelay.c
> > index ef9758638501..f5e5a23d2226 100644
> > --- a/drivers/pinctrl/ti/pinctrl-ti-iodelay.c
> > +++ b/drivers/pinctrl/ti/pinctrl-ti-iodelay.c
> > @@ -822,53 +822,48 @@ MODULE_DEVICE_TABLE(of,
> ti_iodelay_of_match);
> > static int ti_iodelay_probe(struct platform_device *pdev)  {
> >  	struct device *dev = &pdev->dev;
> > -	struct device_node *np = of_node_get(dev->of_node);
> > +	struct device_node *np __free(device_node) =
> > +of_node_get(dev->of_node);
> 
> of_node_put? -------------------------------------------^

You mean use of_node_put here?
of_node_get should be used here. The __free will automatically
do of_node_put when function return.

Thanks,
Peng.

> 
> Best regards
> Uwe