linux-kernel - Re: [PATCH v2 06/13] parisc: use generic sys_fanotify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <d1408856-1d06-4aae-8b44-06e73ac001f8@app.fastmail.com>
Date: Sat, 29 Jun 2024 23:05:37 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "Guenter Roeck" <linux@...ck-us.net>, "Arnd Bergmann" <arnd@...nel.org>
Cc: "Rich Felker" <dalias@...c.org>, "Andreas Larsson" <andreas@...sler.com>,
 linux-mips@...r.kernel.org, guoren <guoren@...nel.org>,
 "Christophe Leroy" <christophe.leroy@...roup.eu>,
 "H. Peter Anvin" <hpa@...or.com>, sparclinux@...r.kernel.org,
 Linux-Arch <linux-arch@...r.kernel.org>, linux-s390@...r.kernel.org,
 "Helge Deller" <deller@....de>, linux-sh@...r.kernel.org,
 "linux-csky@...r.kernel.org" <linux-csky@...r.kernel.org>,
 "Naveen N. Rao" <naveen.n.rao@...ux.ibm.com>,
 "Heiko Carstens" <hca@...ux.ibm.com>,
 "musl@...ts.openwall.com" <musl@...ts.openwall.com>,
 "Nicholas Piggin" <npiggin@...il.com>,
 "Alexander Viro" <viro@...iv.linux.org.uk>,
 "John Paul Adrian Glaubitz" <glaubitz@...sik.fu-berlin.de>,
 "Brian Cain" <bcain@...cinc.com>,
 "Christian Brauner" <brauner@...nel.org>,
 "Thomas Bogendoerfer" <tsbogend@...ha.franken.de>,
 "Xi Ruoyao" <libc-alpha@...rceware.org>, linux-parisc@...r.kernel.org,
 linux-kernel@...r.kernel.org,
 "Adhemerval Zanella Netto" <adhemerval.zanella@...aro.org>,
 linux-hexagon@...r.kernel.org, linux-fsdevel@...r.kernel.org,
 linuxppc-dev@...ts.ozlabs.org, "David S . Miller" <davem@...emloft.net>
Subject: Re: [PATCH v2 06/13] parisc: use generic sys_fanotify_mark implementation

On Sat, Jun 29, 2024, at 19:46, Guenter Roeck wrote:

> Building parisc:allmodconfig ... failed
> --------------
> Error log:
> In file included from fs/notify/fanotify/fanotify_user.c:14:
> include/linux/syscalls.h:248:25: error: conflicting types for 
> 'sys_fanotify_mark'; have 'long int(int,  unsigned int,  u32,  u32,  
> int,  const char *)' {aka 'long int(int,  unsigned int,  unsigned int,  
> unsigned int,  int,  const char *)'}
>   248 |         asmlinkage long 
> sys##name(__MAP(x,__SC_DECL,__VA_ARGS__))       \
>       |                         ^~~
> include/linux/syscalls.h:234:9: note: in expansion of macro 
> '__SYSCALL_DEFINEx'
>   234 |         __SYSCALL_DEFINEx(x, sname, __VA_ARGS__)
>       |         ^~~~~~~~~~~~~~~~~

Thanks for the report, this has escaped my build testing
since I had fanotify disabled on the parisc build.

Sent a fix now and queued it as a fix in the asm-generic
tree:

https://lore.kernel.org/lkml/20240629210359.94426-1-arnd@kernel.org/T/#u

     Arnd