linux-kernel - Re: [PATCH] KVM: PPC: add missing MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c867fc1f-9213-479d-afa3-8210090fd2d5@quicinc.com>
Date: Fri, 28 Jun 2024 20:11:44 -0700
From: Jeff Johnson <quic_jjohnson@...cinc.com>
To: Michael Ellerman <mpe@...erman.id.au>,
        Nicholas Piggin
	<npiggin@...il.com>,
        Christophe Leroy <christophe.leroy@...roup.eu>,
        "Naveen
 N. Rao" <naveen.n.rao@...ux.ibm.com>
CC: <linuxppc-dev@...ts.ozlabs.org>, <kvm@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] KVM: PPC: add missing MODULE_DESCRIPTION() macros

On 6/15/2024 8:18 AM, Jeff Johnson wrote:
> With ARCH=powerpc, make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in arch/powerpc/kvm/test-guest-state-buffer.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in arch/powerpc/kvm/kvm-pr.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in arch/powerpc/kvm/kvm-hv.o
> 
> Add the missing invocations of the MODULE_DESCRIPTION() macro.
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@...cinc.com>
> ---
>  arch/powerpc/kvm/book3s_hv.c               | 1 +
>  arch/powerpc/kvm/book3s_pr.c               | 1 +
>  arch/powerpc/kvm/test-guest-state-buffer.c | 1 +
>  3 files changed, 3 insertions(+)
> 
> diff --git a/arch/powerpc/kvm/book3s_hv.c b/arch/powerpc/kvm/book3s_hv.c
> index daaf7faf21a5..e16c096a2422 100644
> --- a/arch/powerpc/kvm/book3s_hv.c
> +++ b/arch/powerpc/kvm/book3s_hv.c
> @@ -6519,6 +6519,7 @@ static void kvmppc_book3s_exit_hv(void)
>  
>  module_init(kvmppc_book3s_init_hv);
>  module_exit(kvmppc_book3s_exit_hv);
> +MODULE_DESCRIPTION("KVM on Book 3S (POWER7 and later) in hypervisor mode");
>  MODULE_LICENSE("GPL");
>  MODULE_ALIAS_MISCDEV(KVM_MINOR);
>  MODULE_ALIAS("devname:kvm");
> diff --git a/arch/powerpc/kvm/book3s_pr.c b/arch/powerpc/kvm/book3s_pr.c
> index a7d7137ea0c8..7c19744c43cb 100644
> --- a/arch/powerpc/kvm/book3s_pr.c
> +++ b/arch/powerpc/kvm/book3s_pr.c
> @@ -2111,6 +2111,7 @@ void kvmppc_book3s_exit_pr(void)
>  module_init(kvmppc_book3s_init_pr);
>  module_exit(kvmppc_book3s_exit_pr);
>  
> +MODULE_DESCRIPTION("KVM on Book 3S without using hypervisor mode");
>  MODULE_LICENSE("GPL");
>  MODULE_ALIAS_MISCDEV(KVM_MINOR);
>  MODULE_ALIAS("devname:kvm");
> diff --git a/arch/powerpc/kvm/test-guest-state-buffer.c b/arch/powerpc/kvm/test-guest-state-buffer.c
> index 4720b8dc8837..10238556c113 100644
> --- a/arch/powerpc/kvm/test-guest-state-buffer.c
> +++ b/arch/powerpc/kvm/test-guest-state-buffer.c
> @@ -325,4 +325,5 @@ static struct kunit_suite guest_state_buffer_test_suite = {
>  
>  kunit_test_suites(&guest_state_buffer_test_suite);
>  
> +MODULE_DESCRIPTION("KUnit tests for Guest State Buffer APIs");
>  MODULE_LICENSE("GPL");
> 
> ---
> base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670
> change-id: 20240615-md-powerpc-arch-powerpc-kvm-9267fc8b0a8b

Following up to see if anything else is needed from me. Hoping to see this in
linux-next so I can remove it from my tracking spreadsheet :)

/jeff