linux-kernel - Re: [PATCH] s390/dasd: add missing MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0c52c041-6091-4fe2-a519-b8d26e5fc3e8@quicinc.com>
Date: Fri, 28 Jun 2024 20:24:18 -0700
From: Jeff Johnson <quic_jjohnson@...cinc.com>
To: Stefan Haberland <sth@...ux.ibm.com>,
        Jan Hoeppner
	<hoeppner@...ux.ibm.com>,
        Heiko Carstens <hca@...ux.ibm.com>, Vasily Gorbik
	<gor@...ux.ibm.com>,
        Alexander Gordeev <agordeev@...ux.ibm.com>,
        Christian
 Borntraeger <borntraeger@...ux.ibm.com>,
        Sven Schnelle <svens@...ux.ibm.com>
CC: <linux-s390@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] s390/dasd: add missing MODULE_DESCRIPTION() macros

On 6/15/2024 7:19 PM, Jeff Johnson wrote:
> With ARCH=s390, make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/s390/block/dasd_diag_mod.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/s390/block/dasd_eckd_mod.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/s390/block/dasd_fba_mod.o
> 
> Add the missing invocations of the MODULE_DESCRIPTION() macro.
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@...cinc.com>
> ---
> Corrections to these descriptions are welcomed. I'm not an expert in
> this code so in most cases I've taken these descriptions directly from
> code comments, Kconfig descriptions, or git logs.  History has shown
> that in some cases these are originally wrong due to cut-n-paste
> errors, and in other cases the drivers have evolved such that the
> original information is no longer accurate.
> ---
>  drivers/s390/block/dasd_diag.c | 1 +
>  drivers/s390/block/dasd_eckd.c | 1 +
>  drivers/s390/block/dasd_fba.c  | 1 +
>  3 files changed, 3 insertions(+)
> 
> diff --git a/drivers/s390/block/dasd_diag.c b/drivers/s390/block/dasd_diag.c
> index ea4b1d01bb76..8245b742e4a2 100644
> --- a/drivers/s390/block/dasd_diag.c
> +++ b/drivers/s390/block/dasd_diag.c
> @@ -29,6 +29,7 @@
>  #include "dasd_int.h"
>  #include "dasd_diag.h"
>  
> +MODULE_DESCRIPTION("S/390 Support for DIAG access to DASD Disks");
>  MODULE_LICENSE("GPL");
>  
>  /* The maximum number of blocks per request (max_blocks) is dependent on the
> diff --git a/drivers/s390/block/dasd_eckd.c b/drivers/s390/block/dasd_eckd.c
> index 2f16f543079b..f8113974cfba 100644
> --- a/drivers/s390/block/dasd_eckd.c
> +++ b/drivers/s390/block/dasd_eckd.c
> @@ -44,6 +44,7 @@
>  /* 64k are 128 x 512 byte sectors  */
>  #define DASD_RAW_SECTORS_PER_TRACK 128
>  
> +MODULE_DESCRIPTION("S/390 DASD ECKD Disks device driver");
>  MODULE_LICENSE("GPL");
>  
>  static struct dasd_discipline dasd_eckd_discipline;
> diff --git a/drivers/s390/block/dasd_fba.c b/drivers/s390/block/dasd_fba.c
> index 361e9bd75257..9ef7b168aba8 100644
> --- a/drivers/s390/block/dasd_fba.c
> +++ b/drivers/s390/block/dasd_fba.c
> @@ -32,6 +32,7 @@
>  #define DASD_FBA_CCW_LOCATE 0x43
>  #define DASD_FBA_CCW_DEFINE_EXTENT 0x63
>  
> +MODULE_DESCRIPTION("S/390 DASD FBA Disks device driver");
>  MODULE_LICENSE("GPL");
>  
>  static struct dasd_discipline dasd_fba_discipline;
> 
> ---
> base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670
> change-id: 20240615-md-s390-drivers-s390-block-dasd-9a143c6ca093

Following up to see if anything else is needed from me. Hoping to see this in
linux-next so I can remove it from my tracking spreadsheet :)

/jeff