linux-kernel - Re: [PATCH] ARM, sched/topology: Check return value of kcalloc()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <9BB5B7C2-C35C-4F5C-9DC2-AD015288A992@toblux.com>
Date: Fri, 28 Jun 2024 21:09:22 -0700
From: Thorsten Blum <thorsten.blum@...lux.com>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: mingo@...nel.org,
 sshegde@...ux.ibm.com,
 linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM, sched/topology: Check return value of kcalloc()

On 28. Jun 2024, at 14:55, Russell King (Oracle) <linux@...linux.org.uk> wrote:
> On Fri, Jun 28, 2024 at 09:43:51PM +0200, Thorsten Blum wrote:
>> Check the return value of kcalloc() and return early if memory
>> allocation fails.
> 
> If we fail this allocation even with your fix, how likely is it that the
> system will boot and manage to run userspace?

I thought about panicking, but wasn't sure if it's justified.

But since it would just crash anyway when accessing a NULL pointer
later on, it's probably best to panic() if the memory allocation fails.

I'll submit a v2 shortly.

Thanks,
Thorsten