linux-kernel - Re: [PATCH v2 2/2] media: i2c: Add driver for Sony IMX728

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a805ace8-6777-4616-b3ef-b475d1b71114@web.de>
Date: Sun, 30 Jun 2024 08:15:39 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Spencer Hill <shill@...ngineering.com>, linux-media@...r.kernel.org,
 devicetree@...r.kernel.org, imx@...ts.linux.dev, kernel@...gutronix.de,
 linux-arm-kernel@...ts.infradead.org,
 Alexander Stein <alexander.stein@...tq-group.com>,
 Conor Dooley <conor+dt@...nel.org>,
 Dave Stevenson <dave.stevenson@...pberrypi.com>,
 Fabio Estevam <festevam@...il.com>,
 Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
 Mauro Carvalho Chehab <mchehab@...nel.org>, Rob Herring <robh@...nel.org>,
 Sakari Ailus <sakari.ailus@...ux.intel.com>,
 Sascha Hauer <s.hauer@...gutronix.de>, Shawn Guo <shawnguo@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 2/2] media: i2c: Add driver for Sony IMX728

…
> +++ b/drivers/media/i2c/imx728.c
> @@ -0,0 +1,4660 @@
…
> +static int imx728_set_fmt(struct v4l2_subdev *sd,
> +                         struct v4l2_subdev_state *state,
> +                         struct v4l2_subdev_format *fmt)
> +{
…
> +       mutex_lock(&imx728->lock);
> +
> +       fmt->format.field = V4L2_FIELD_NONE;
…
> +       *format = fmt->format;
> +
> +done:
> +       mutex_unlock(&imx728->lock);
> +
> +       return ret;
> +}
…

Under which circumstances would you become interested to apply a statement
like “guard(mutex)(&imx728->lock);”?
https://elixir.bootlin.com/linux/v6.10-rc5/source/include/linux/mutex.h#L196

Regards,
Markus