linux-kernel - Re: [PATCH] clk: sunxi-ng: common: Don't call hw_to_ccu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <171976163761.1183893.10044135406471629615.b4-ty@csie.org>
Date: Sun, 30 Jun 2024 23:34:02 +0800
From: Chen-Yu Tsai <wens@...nel.org>
To: Michael Turquette <mturquette@...libre.com>,
	Stephen Boyd <sboyd@...nel.org>,
	Jernej Skrabec <jernej.skrabec@...il.com>,
	Samuel Holland <samuel@...lland.org>,
	Maxime Ripard <mripard@...nel.org>,
	Frank Oltmanns <frank@...manns.dev>
Cc: Chen-Yu Tsai <wens@...e.org>,
	Måns Rullgård <mans@...sr.com>,
	linux-clk@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-sunxi@...ts.linux.dev,
	linux-kernel@...r.kernel.org,
	"Robert J. Pafford" <pafford.9@...keyemail.osu.edu>,
	stable@...r.kernel.org
Subject: Re: [PATCH] clk: sunxi-ng: common: Don't call hw_to_ccu_common on hw without common

From: Chen-Yu Tsai <wens@...e.org>

On Sun, 23 Jun 2024 10:45:58 +0200, Frank Oltmanns wrote:
> In order to set the rate range of a hw sunxi_ccu_probe calls
> hw_to_ccu_common() assuming all entries in desc->ccu_clks are contained
> in a ccu_common struct. This assumption is incorrect and, in
> consequence, causes invalid pointer de-references.
> 
> Remove the faulty call. Instead, add one more loop that iterates over
> the ccu_clks and sets the rate range, if required.
> 
> [...]

Applied to clk-fixes-for-6.10 in git@...hub.com:linux-sunxi/linux-sunxi.git, thanks!

[1/1] clk: sunxi-ng: common: Don't call hw_to_ccu_common on hw without common
      commit: ea977d742507e534d9fe4f4d74256f6b7f589338

Best regards,
-- 
Chen-Yu Tsai <wens@...e.org>