linux-kernel - Re: [PATCH 4/4] clk: eyeq: add driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202407010208.41nIsx5I-lkp@intel.com>
Date: Mon, 1 Jul 2024 03:29:25 +0800
From: kernel test robot <lkp@...el.com>
To: Théo Lebrun <theo.lebrun@...tlin.com>,
	Michael Turquette <mturquette@...libre.com>,
	Stephen Boyd <sboyd@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>
Cc: oe-kbuild-all@...ts.linux.dev, linux-clk@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	Vladimir Kondratiev <vladimir.kondratiev@...ileye.com>,
	Grégory Clement <gregory.clement@...tlin.com>,
	Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
	Tawfik Bayouk <tawfik.bayouk@...ileye.com>,
	Théo Lebrun <theo.lebrun@...tlin.com>
Subject: Re: [PATCH 4/4] clk: eyeq: add driver

Hi Théo,

kernel test robot noticed the following build errors:

[auto build test ERROR on f2661062f16b2de5d7b6a5c42a9a5c96326b8454]

url:    https://github.com/intel-lab-lkp/linux/commits/Th-o-Lebrun/Revert-dt-bindings-clock-mobileye-eyeq5-clk-add-bindings/20240630-062710
base:   f2661062f16b2de5d7b6a5c42a9a5c96326b8454
patch link:    https://lore.kernel.org/r/20240628-mbly-clk-v1-4-edb1e29ea4c1%40bootlin.com
patch subject: [PATCH 4/4] clk: eyeq: add driver
config: i386-allmodconfig
compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0
reproduce (this is a W=1 build):

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202407010208.41nIsx5I-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/clk/clk-eyeq.c: In function 'eqc_probe_init_plls':
>> drivers/clk/clk-eyeq.c:264:23: error: implicit declaration of function 'readq'; did you mean 'readl'? [-Werror=implicit-function-declaration]
     264 |                 val = readq(priv->base + pll->reg64);
         |                       ^~~~~
         |                       readl
   cc1: some warnings being treated as errors


vim +264 drivers/clk/clk-eyeq.c

   249	
   250	static void eqc_probe_init_plls(struct device *dev, struct eqc_priv *priv)
   251	{
   252		const struct eqc_match_data *data = priv->data;
   253		unsigned long mult, div, acc;
   254		const struct eqc_pll *pll;
   255		struct clk_hw *hw;
   256		unsigned int i;
   257		u32 r0, r1;
   258		u64 val;
   259		int ret;
   260	
   261		for (i = 0; i < data->pll_count; i++) {
   262			pll = &data->plls[i];
   263	
 > 264			val = readq(priv->base + pll->reg64);
   265			r0 = val;
   266			r1 = val >> 32;
   267	
   268			ret = eqc_pll_parse_registers(r0, r1, &mult, &div, &acc);
   269			if (ret) {
   270				dev_warn(dev, "failed parsing state of %s\n", pll->name);
   271				priv->cells->hws[pll->index] = ERR_PTR(ret);
   272				continue;
   273			}
   274	
   275			hw = clk_hw_register_fixed_factor_with_accuracy_fwname(dev,
   276					dev->of_node, pll->name, "ref", 0, mult, div, acc);
   277			priv->cells->hws[pll->index] = hw;
   278			if (IS_ERR(hw))
   279				dev_warn(dev, "failed registering %s: %pe\n", pll->name, hw);
   280		}
   281	}
   282	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

View attachment "reproduce" of type "text/plain" (393 bytes)

View attachment "config" of type "text/plain" (383398 bytes)