lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240701-evolve-unbutton-ef7d913ad69f@spud>
Date: Mon, 1 Jul 2024 15:42:37 +0100
From: Conor Dooley <conor@...nel.org>
To: Philipp Zabel <p.zabel@...gutronix.de>
Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-input@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel@...gutronix.de
Subject: Re: [PATCH v2 1/2] dt-bindings: input: touchscreen: exc3000: add
 EXC81W32

On Mon, Jul 01, 2024 at 02:47:50PM +0200, Philipp Zabel wrote:
> Hi Conor,
> 
> On Fr, 2024-06-28 at 17:21 +0100, Conor Dooley wrote:
> > On Fri, Jun 28, 2024 at 10:35:51AM +0200, Philipp Zabel wrote:
> > > Add compatible for EXC81W32 touchscreen controllers.
> > 
> > Could you please mention in your commit messages what makes a fallback
> > compatible inappropriate here?
> 
> thank for pointing this out. Actually, I'm not sure a fallback
> compatible is inappropriate at all. There just is none currently, even
> though EXC80H60 and EXC80H84 already look compatible to me.
> 
> To my understanding, there's EXC80[WH]{32,46,60,84} models, that should
> only differ in ball pitch (W or H) and targeted display size (the last
> number).
> I don't know if there are actual relevant differences between what I
> assume are model generations, such as EXC80 to EXC81. At least the
> limited currently implemented feature set in the exc3000 driver is
> identical.
> 
> Given that EXC80H60, EXC80H84, and now EXC81W32 all share the same 16K
> resolution and the same message format (possible differences in
> capability to measure touch area nonwithstanding), should I prepend
> this series with a patch:

If you're prepared to update the two users to avoid adding more
dtbs_check warnings, sure.

Thanks,
Conor.

> 
> @@ -14,10 +14,13 @@
>  
>  properties:
>    compatible:
> -    enum:
> -      - eeti,exc3000
> -      - eeti,exc80h60
> -      - eeti,exc80h84
> +    oneOf:
> +      - const: eeti,exc3000
> +      - items:
> +          - enum:
> +              - eeti,exc80h60
> +          - const: eeti,exc80h84
> +      - const: eeti,exc80h84
>    reg:
>      const: 0x2a
>    interrupts:
> 
> regards
> Philipp

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ