linux-kernel - Re: [PATCH 4/5] x86/vgtod: Remove unused typedef gtod_long

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4d4efa29-8a6e-40de-8979-3fd13d6bd4db@arm.com>
Date: Mon, 1 Jul 2024 16:19:20 +0100
From: Vincenzo Frascino <vincenzo.frascino@....com>
To: Anna-Maria Behnsen <anna-maria@...utronix.de>,
 Andy Lutomirski <luto@...nel.org>, Thomas Gleixner <tglx@...utronix.de>
Cc: linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...hat.com>,
 Borislav Petkov <bp@...en8.de>, Dave Hansen <dave.hansen@...ux.intel.com>,
 "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org
Subject: Re: [PATCH 4/5] x86/vgtod: Remove unused typedef gtod_long_t

On 01/07/2024 15:47, Anna-Maria Behnsen wrote:
> The typedef gtod_long_t is not used anymore so remove it.
> 
> The header file contains then only includes dependent on
> CONFIG_GENERIC_GETTIMEOFDAY to not break ARCH=um. Nevertheless, keep the
> header file only with those includes to prevent spreading ifdeffery all
> over the place.
> 
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: Borislav Petkov <bp@...en8.de>
> Cc: Dave Hansen <dave.hansen@...ux.intel.com>
> Cc: H. Peter Anvin <hpa@...or.com>
> Cc: x86@...nel.org
> Signed-off-by: Anna-Maria Behnsen <anna-maria@...utronix.de>

Reviewed-by: Vincenzo Frascino <vincenzo.frascino@....com>

> ---
>  arch/x86/include/asm/vgtod.h | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/arch/x86/include/asm/vgtod.h b/arch/x86/include/asm/vgtod.h
> index 7aa38b2ad8a9..a0ce291abcae 100644
> --- a/arch/x86/include/asm/vgtod.h
> +++ b/arch/x86/include/asm/vgtod.h
> @@ -14,11 +14,6 @@
>  
>  #include <uapi/linux/time.h>
>  
> -#ifdef BUILD_VDSO32_64
> -typedef u64 gtod_long_t;
> -#else
> -typedef unsigned long gtod_long_t;
> -#endif
>  #endif /* CONFIG_GENERIC_GETTIMEOFDAY */
>  
>  #endif /* _ASM_X86_VGTOD_H */
> 

-- 
Regards,
Vincenzo