linux-kernel - Re: [PATCH v3 06/11] KVM: VMX: Expand FRED kvm entry with event data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240701083956.4460bb06@jacob-builder>
Date: Mon, 1 Jul 2024 08:39:56 -0700
From: Jacob Pan <jacob.jun.pan@...ux.intel.com>
To: Xin Li <xin@...or.com>
Cc: X86 Kernel <x86@...nel.org>, Sean Christopherson <seanjc@...gle.com>,
 LKML <linux-kernel@...r.kernel.org>, Thomas Gleixner <tglx@...utronix.de>,
 Dave Hansen <dave.hansen@...el.com>, "H. Peter Anvin" <hpa@...or.com>, Ingo
 Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>, Xin Li
 <xin3.li@...el.com>, linux-perf-users@...r.kernel.org, Peter Zijlstra
 <peterz@...radead.org>, Paolo Bonzini <pbonzini@...hat.com>, Tony Luck
 <tony.luck@...el.com>, Andy Lutomirski <luto@...nel.org>, acme@...nel.org,
 kan.liang@...ux.intel.com, Andi Kleen <andi.kleen@...el.com>, "Mehta,
 Sohil" <sohil.mehta@...el.com>, Zeng Guang <guang.zeng@...el.com>,
 jacob.jun.pan@...ux.intel.com
Subject: Re: [PATCH v3 06/11] KVM: VMX: Expand FRED kvm entry with event
 data

On Fri, 28 Jun 2024 21:01:28 -0700, Xin Li <xin@...or.com> wrote:

> On 6/28/2024 1:18 PM, Jacob Pan wrote:
> > From: Zeng Guang <guang.zeng@...el.com>
> > 
> > For VM exits caused by events (NMI, #DB, and #PF) delivered by FRED, the
> > event data is saved in the exit-qualification field. (FRED spec.
> > 10.6.2)  
> 
> I don't like mentioning #DB/#PF here, they belong to the guest that was 
> running, and KVM handles them.
It is part of the spec.

> While NMIs belong to host, and the host NMI handler needs event data
> saved in VMCS in NMI induced VM exits.
> 
> Or you paint a full picture.
I will add your explanation that #DB/#PF belong to the guest so readers can
get a full picture of both usage and spec.
> 
> > Expand FRED KVM entry interface to include the event data obtained from
> > the exit qualification.
> > 
> > Signed-off-by: Zeng Guang <guang.zeng@...el.com>
> > Signed-off-by: Jacob Pan <jacob.jun.pan@...ux.intel.com>  
> 

Thanks,

Jacob