linux-kernel - Re: [PATCH 1/2] mm/zsmalloc: fix class per-fullness zspage counts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8163966f-d31d-425c-97cb-3d18ab28ac1f@linux.dev>
Date: Mon, 1 Jul 2024 10:49:13 +0800
From: Chengming Zhou <chengming.zhou@...ux.dev>
To: Sergey Senozhatsky <senozhatsky@...omium.org>
Cc: akpm@...ux-foundation.org, minchan@...nel.org, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] mm/zsmalloc: fix class per-fullness zspage counts

On 2024/7/1 10:20, Chengming Zhou wrote:
> On 2024/7/1 09:37, Sergey Senozhatsky wrote:
>> On (24/06/28 11:19), Chengming Zhou wrote:
>>> Andrew, could you please help to change the subject as Sergey asked?
>>> Sorry, I should have noted these details in the changelog when I wrote
>>> this subject.
>>
>> Chengming, can I ask you to resend these patches with a proper commit
>> message?
> 
> Of course, will update and send later.

I just pulled mm/mm-unstable and ready to update, but find Andrew has 
already helped to change the subject and commit message as below, which
is great enough! Thanks!

commit 84d0abc5905bbdf29dc7ff8083d21145d78a3ffe
Author: Chengming Zhou <chengming.zhou@...ux.dev>
Date:   Thu Jun 27 15:59:58 2024 +0800

     mm/zsmalloc: clarify class per-fullness zspage counts

     We always use insert_zspage() and remove_zspage() to update zspage's
     fullness location, which will account correctly.

     But this special async free path use "splice" instead of 
remove_zspage(),
     so the per-fullness zspage count for ZS_INUSE_RATIO_0 won't decrease.

     Clean things up by decreasing when iterate over the zspage free list.

     This doesn't actually fix anything.  ZS_INUSE_RATIO_0 is just a
     "placeholder" which is never used anywhere.

     Link: 
https://lkml.kernel.org/r/20240627075959.611783-1-chengming.zhou@linux.dev
     Signed-off-by: Chengming Zhou <chengming.zhou@...ux.dev>
     Cc: Minchan Kim <minchan@...nel.org>
     Cc: Sergey Senozhatsky <senozhatsky@...omium.org>
     Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>