linux-kernel - Re: [PATCH 0/3] Add Per-transport SCMI debug statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZoLXkWur5TZaQzkm@pluto>
Date: Mon, 1 Jul 2024 17:21:37 +0100
From: Cristian Marussi <cristian.marussi@....com>
To: Luke Parkin <luke.parkin@....com>
Cc: linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	arm-scmi@...r.kernel.org, sudeep.holla@....com,
	cristian.marussi@....com
Subject: Re: [PATCH 0/3] Add Per-transport SCMI debug statistics

On Mon, Jul 01, 2024 at 03:28:48PM +0100, Luke Parkin wrote:
> Hi,
> 
> This series adds support for tracking Arm SCMI statistics, [Patch 2]
> A config option to enable this, [Patch 1] 
> And in [Patch 3] a selection of new debugfs entries to present these statistics
> 
> These statistics are per transport instance, and will be a helpful resource when
> debugging the SCMI and running tests.
> 
> Based on v6.9, Tested on Arm Juno [1]
> 
> Thanks,
> Luke
> 
> [1]: https://www.arm.com/products/development-tools/development-boards/juno-arm-dev-platform
> 
> Luke Parkin (3):
>   Add Kconfig option for scmi debug statistics
>   Track basic SCMI statistics
>   Create debugfs files for statistics
> 
>  drivers/firmware/arm_scmi/Kconfig  | 10 +++++
>  drivers/firmware/arm_scmi/driver.c | 61 +++++++++++++++++++++++++++++-
>  2 files changed, 69 insertions(+), 2 deletions(-)
> 

All in all, seems to me a good start, please address or dispute my (and
possibly other reviewers) observations in V2.

Thanks,
Cristian