linux-kernel - Re: [PATCH v4 2/2] dt-bindings: input: Update dtbinding for adp5588

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 01 Jul 2024 10:27:55 -0600
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Utsav Agarwal <utsav.agarwal@...log.com>
Cc: Krzysztof Kozlowski <krzk+dt@...nel.org>, linux-kernel@...r.kernel.org, 
 Michael Hennerich <michael.hennerich@...log.com>, 
 devicetree@...r.kernel.org, 
 Arturs Artamonovs <arturs.artamonovs@...log.com>, 
 Nuno Sá <nuno.sa@...log.com>, 
 Dmitry Torokhov <dmitry.torokhov@...il.com>, 
 Vasileios Bimpikas <vasileios.bimpikas@...log.com>, 
 Conor Dooley <conor+dt@...nel.org>, 
 Oliver Gaskell <oliver.gaskell@...log.com>, linux-input@...r.kernel.org
Subject: Re: [PATCH v4 2/2] dt-bindings: input: Update dtbinding for
 adp5588


On Mon, 01 Jul 2024 16:04:51 +0100, Utsav Agarwal wrote:
> Updating dt bindings for adp5588. Following properties are now made
> optional:
> 	- interrupts
> 	- keypad,num-rows
> 	- keypad,num-columns
> 	- linux,keymap
> The proposed new property "gpio-only" has been added as an optional
> property with an additional example.
> 
> Signed-off-by: Utsav Agarwal <utsav.agarwal@...log.com>
> ---
>  .../devicetree/bindings/input/adi,adp5588.yaml     | 28 ++++++++++++++++++----
>  1 file changed, 24 insertions(+), 4 deletions(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/input/adi,adp5588.yaml: gpio-only: missing type definition

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240701-adp5588_gpio_support-v4-2-44bba0445e90@analog.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.