linux-kernel - Re: [EXTERNAL] Re: [PATCH v1] ASoc: tas2781: Add name_prefix as the prefix name of DSP firmwares and calibrated data files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7a44a36c-6f95-4c5b-a86d-044f9ad13ac1@sirena.org.uk>
Date: Mon, 1 Jul 2024 18:05:45 +0100
From: Mark Brown <broonie@...nel.org>
To: "Ding, Shenghao" <shenghao-ding@...com>
Cc: "andriy.shevchenko@...ux.intel.com" <andriy.shevchenko@...ux.intel.com>,
	"lgirdwood@...il.com" <lgirdwood@...il.com>,
	"perex@...ex.cz" <perex@...ex.cz>,
	"pierre-louis.bossart@...ux.intel.com" <pierre-louis.bossart@...ux.intel.com>,
	"13916275206@....com" <13916275206@....com>,
	"zhourui@...qin.com" <zhourui@...qin.com>,
	"alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
	"Salazar, Ivan" <i-salazar@...com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Chadha, Jasjot Singh" <j-chadha@...com>,
	"liam.r.girdwood@...el.com" <liam.r.girdwood@...el.com>,
	"Yue, Jaden" <jaden-yue@...com>,
	"yung-chuan.liao@...ux.intel.com" <yung-chuan.liao@...ux.intel.com>,
	"Rao, Dipa" <dipa@...com>,
	"yuhsuan@...gle.com" <yuhsuan@...gle.com>,
	"Lo, Henry" <henry.lo@...com>, "tiwai@...e.de" <tiwai@...e.de>,
	"Xu, Baojun" <baojun.xu@...com>, "soyer@....hu" <soyer@....hu>,
	"Baojun.Xu@....com" <Baojun.Xu@....com>,
	"judyhsiao@...gle.com" <judyhsiao@...gle.com>,
	"Navada Kanyana, Mukund" <navada@...com>,
	"cujomalainey@...gle.com" <cujomalainey@...gle.com>,
	"Kutty, Aanya" <aanya@...com>,
	"Mahmud, Nayeem" <nayeem.mahmud@...com>,
	"savyasanchi.shukla@...radyne.com" <savyasanchi.shukla@...radyne.com>,
	"flaviopr@...rosoft.com" <flaviopr@...rosoft.com>,
	"Ji, Jesse" <jesse-ji@...com>,
	"darren.ye@...iatek.com" <darren.ye@...iatek.com>
Subject: Re: [EXTERNAL] Re: [PATCH v1] ASoc: tas2781: Add name_prefix as the
 prefix name of DSP firmwares and calibrated data files

On Mon, Jul 01, 2024 at 02:00:13PM +0000, Ding, Shenghao wrote:

> > I'll apply this but I do wonder if it's worth falling back to trying to load the
> > unprefixed name if we fail to load the prefixed one.

> If fail to load dsp firmware, the driver won't load unprefixed name firmware, 
> but switch tas2563/tas2781 to bypass-dsp mode automatically.
> In this mode, smartamp become simple amp.
> These day, I met a case from one of my customers, they put 2 pieces of tas2563, 
> and 2 pieces of tas2781 in the same i2c bus. In order to identify tas2563 and 
> tas2781, I think name_prefix is a good solution for this case.
> Looking forward to your comment. Thanks.

Yes, the name_prefix is a good idea and probably people want things
specifically tuned for the DSP - I was thinking about error handling or
upgrade cases where wrong calibration might work better.  Bypass mode
means the device will still function at least.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)