linux-kernel - Re: [PATCH v3 11/11] KVM: X86: Use common code for PV IPIs in linux guest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <37fbf57e-8f3d-447c-acf8-c1485c490b76@zytor.com>
Date: Mon, 1 Jul 2024 10:13:43 -0700
From: Xin Li <xin@...or.com>
To: Jacob Pan <jacob.jun.pan@...ux.intel.com>
Cc: X86 Kernel <x86@...nel.org>, Sean Christopherson <seanjc@...gle.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Dave Hansen <dave.hansen@...el.com>, "H. Peter Anvin" <hpa@...or.com>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Xin Li <xin3.li@...el.com>, linux-perf-users@...r.kernel.org,
        Peter Zijlstra <peterz@...radead.org>,
        Paolo Bonzini <pbonzini@...hat.com>, Tony Luck <tony.luck@...el.com>,
        Andy Lutomirski <luto@...nel.org>, acme@...nel.org,
        kan.liang@...ux.intel.com, Andi Kleen
 <andi.kleen@...el.com>,
        "Mehta, Sohil" <sohil.mehta@...el.com>,
        Zeng Guang <guang.zeng@...el.com>
Subject: Re: [PATCH v3 11/11] KVM: X86: Use common code for PV IPIs in linux
 guest

On 7/1/2024 9:38 AM, Jacob Pan wrote:
> 
> On Sat, 29 Jun 2024 11:38:10 -0700, Xin Li <xin@...or.com> wrote:
> 
>> On 6/28/2024 1:18 PM, Jacob Pan wrote:
>>> Paravirtual apic hooks to enable PV IPIs for KVM if the "send IPI"
>>
>> s/Paravirtual apic/Paravirtualize APIC/
> 
> Paravirtual APIC makes sense to me. This is also the same language used in
> previous commits.

"Paravirtual apic hooks to enable..."

It needs to start with a verb, I can't read it as adj.

> 
> How about:
> 
> "The paravirtual APIC hooks in KVM, some of which are used for sending PV
> IPIs, can reuse common code for ICR preparation. This shared code also
> encompasses NMI-source reporting when in effect."

LGTM.

> 
>>> hypercall is available. Reuse common code for ICR preparation which
>>> covers NMI-source reporting if in effect.
>>
>> I see a lot of "NMI source". Should we use "NMI-source" in all places?
> Not really, here NMI-source is a compound modifier before noun "reporting".
> 
> For other places, hyphen(-) is not needed if it is just a noun. e.g.
> "partial due to unknown NMI sources"
> 
> I will go through the patchset to make sure they are consistent.

Right, make them consistent.