linux-kernel - Re: [PATCH 3/4] Input: simplify event handling logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <kthymccoagu5kmhtr42dnugjzpf3wwesd63eqttyoxmbijoy4k@qe7pbdn5kmdx>
Date: Mon, 1 Jul 2024 19:54:25 +0200
From: Benjamin Tissoires <bentiss@...nel.org>
To: Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc: linux-input@...r.kernel.org, Jeff LaBundy <jeff@...undy.com>, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] Input: simplify event handling logic

On Jul 01 2024, Dmitry Torokhov wrote:
> On Mon, Jul 01, 2024 at 09:41:22AM +0200, Benjamin Tissoires wrote:
> > On Jun 30 2024, Dmitry Torokhov wrote:
> > >  /*
> > >   * Pass values first through all filters and then, if event has not been
> > >   * filtered out, through all open handles. This function is called with
> > 
> > Nitpick: maybe that comment above input_pass_values() should also be
> > amended now that the processing is more straightforward?
> 
> I think the comment is still accurate from the higher POV. We do want to
> send the event(s) first through all the filters and the remainder is
> through the handlers. This is achieved by placing filters at the head of
> the list of handles attacher to the device, and placing regular handles
> at the tail of the list.

Oh right, I missed that in my review.

> 
> Do you want me to expand the comment?

Yeah, maybe add the blurb from above in the comment so we don't ask
further questions next time we revisit that code. And given that you
need to respin the series, it should be all right :)

Cheers,
Benjamin