linux-kernel - Re: [PATCH v2 02/13] arm64: dts: layerscape: add platform special compatible string for gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZoL6xVdj/rEgK0H/@lizhi-Precision-Tower-5810>
Date: Mon, 1 Jul 2024 14:51:49 -0400
From: Frank Li <Frank.li@....com>
To: Rob Herring <robh@...nel.org>
Cc: Shawn Guo <shawnguo@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	"moderated list:ARM/FREESCALE LAYERSCAPE ARM ARCHITECTURE" <linux-arm-kernel@...ts.infradead.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@...r.kernel.org>,
	open list <linux-kernel@...r.kernel.org>, imx@...ts.linux.dev
Subject: Re: [PATCH v2 02/13] arm64: dts: layerscape: add platform special
 compatible string for gpio

On Mon, Jul 01, 2024 at 10:43:32AM -0600, Rob Herring wrote:
> On Wed, Jun 26, 2024 at 2:26 PM Frank Li <Frank.Li@....com> wrote:
> >
> > Add platform special compatible string for all gpio controller to fix
> > below warning.
> >
> >  gpio@...0000: compatible: 'oneOf' conditional failed, one must be fixed:
> >         ['fsl,qoriq-gpio'] is too short
> >         'fsl,qoriq-gpio' is not one of ['fsl,mpc5121-gpio', 'fsl,mpc5125-gpio', 'fsl,mpc8349-gpio', 'fsl,mpc8572-gpio', 'fsl,mpc8610-gpio', 'fsl,pq3-gpio']
> >         'fsl,qoriq-gpio' is not one of ['fsl,ls1021a-gpio', 'fsl,ls1028a-gpio', 'fsl,ls1043a-gpio', 'fsl,ls1088a-gpio', 'fsl,ls2080a-gpio']
> >
> > Signed-off-by: Frank Li <Frank.Li@....com>
> > ---
> >  arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi | 4 ++--
> >  arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 8 ++++----
> >  arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 8 ++++----
> >  3 files changed, 10 insertions(+), 10 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
> > index 2e1cddc11bf47..1b6ab9550cce9 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi
> > @@ -407,7 +407,7 @@ duart1: serial@...0600 {
> >                 };
> >
> >                 gpio0: gpio@...0000 {
> > -                       compatible = "fsl,qoriq-gpio";
> > +                       compatible = "fsl,ls1021a-gpio", "fsl,qoriq-gpio";
> >                         reg = <0x0 0x2300000 0x0 0x10000>;
> >                         interrupts = <GIC_SPI 66 IRQ_TYPE_LEVEL_HIGH>;
> >                         gpio-controller;
> > @@ -417,7 +417,7 @@ gpio0: gpio@...0000 {
> >                 };
> >
> >                 gpio1: gpio@...0000 {
> > -                       compatible = "fsl,qoriq-gpio";
> > +                       compatible = "fsl,ls1021a-gpio", "fsl,qoriq-gpio";
> >                         reg = <0x0 0x2310000 0x0 0x10000>;
> >                         interrupts = <GIC_SPI 67 IRQ_TYPE_LEVEL_HIGH>;
> >                         gpio-controller;
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > index f8c9489507e7a..524b44f424272 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> > @@ -589,7 +589,7 @@ duart3: serial@...0600 {
> >                 };
> >
> >                 gpio0: gpio@...0000 {
> > -                       compatible = "fsl,qoriq-gpio";
> > +                       compatible = "fsl,ls1046a-gpio", "fsl,qoriq-gpio";
> 
> ls1046a isn't documented.

Sorry, there are local dt-binding update patch, which I forget sent out.
So I have not found this problem when I sent out dts change.

Frank 

> 
> Rob