linux-kernel - Re: [PATCH 00/53] Let create*_workqueue() accept a printf-style format string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZoMF1ZydZUusxRcf@slm.duckdns.org>
Date: Mon, 1 Jul 2024 09:39:01 -1000
From: Tejun Heo <tj@...nel.org>
To: Bart Van Assche <bvanassche@....org>
Cc: Lai Jiangshan <jiangshanlai@...il.com>,
	"Martin K . Petersen" <martin.petersen@...cle.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 00/53] Let create*_workqueue() accept a printf-style
 format string

Hello, Bart.

On Sun, Jun 30, 2024 at 03:26:18PM -0700, Bart Van Assche wrote:
> 1. Introduce the create*_workqueue2() macros that accept a printf-style
>    format string and argument list.

I don't think we want to update create_workqueue() interface at all. Please
convert them to use alloc_workqueue() instead. Once we convert all
create_workqueue() users then we can just drop the old interface.

The challenge with converging to alloc_workqueue() interface is that the
conversion needs to explicitly decide whether WQ_MEM_RECLAIM is needed or
not but that shouldn't be *too* difficult.

Thanks.

-- 
tejun