linux-kernel - Re: linux-next: Fixes tag needs some work in the pci tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240701201833.GB272504@rocinante>
Date: Tue, 2 Jul 2024 05:18:33 +0900
From: Krzysztof Wilczyński <kw@...ux.com>
To: Niklas Cassel <cassel@...nel.org>
Cc: Stephen Rothwell <sfr@...b.auug.org.au>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Lorenzo Pieralisi <lpieralisi@...nel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: linux-next: Fixes tag needs some work in the pci tree

Hello,

> > In commit
> > 
> >   aaf840725904 ("PCI: dw-rockchip: Depend on PCI_ENDPOINT if building endpoint mode support")
> > 
> > Fixes tag
> > 
> >   Fixes: 9b2ba393b3a6 ("PCI: dw-rockchip: Add endpoint mode support")
> > 
> > has these problem(s):
> > 
> >   - Target SHA1 does not exist
> > 
> > Maybe you meant
> > 
> > Fixes: 728538f5e806 ("PCI: dw-rockchip: Add endpoint mode support")
[...]
> The branch was rebased so the SHA1 changed.
> 
> Perhaps the maintainers could update the Fixes tag.
> 
> (Personally, I would just squash the small fix with the commit that it fixes.)

I will squash the patch that adds PCI_ENDPOINT dependency with the rest of
the series, and then drop the Fixes: tag afterwards, since it would not
longer be needed.

	Krzysztof