linux-kernel - Re: [PATCH] clk: mediatek: mt8183: Only enable runtime PM on mt8183-mfgcfg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d3d91a26f205925c4d0197fbd977a6d3.sboyd@kernel.org>
Date: Mon, 01 Jul 2024 13:49:30 -0700
From: Stephen Boyd <sboyd@...nel.org>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, Matthias Brugger <matthias.bgg@...il.com>, Michael Turquette <mturquette@...libre.com>, Pin-yen Lin <treapking@...omium.org>
Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org, Chen-Yu Tsai <wenst@...omium.org>, linux-clk@...r.kernel.org, Pin-yen Lin <treapking@...omium.org>
Subject: Re: [PATCH] clk: mediatek: mt8183: Only enable runtime PM on mt8183-mfgcfg

Quoting Pin-yen Lin (2024-06-13 05:02:28)
> Commit 2f7b1d8b5505 ("clk: mediatek: Do a runtime PM get on controllers
> during probe") enabled runtime PM for all mediatek clock controllers,
> but this introduced an issue on the resume path.
> 
> If a device resumes earlier than the clock controller and calls
> clk_prepare() when runtime PM is enabled on the controller, it will end
> up calling clk_pm_runtime_get(). But the subsequent
> pm_runtime_resume_and_get() call will fail because the runtime PM is
> temporarily disabled during suspend.
> 
> To workaround this, introduce a need_runtime_pm flag and only enable it
> on mt8183-mfgcfg, which is the driver that observed deadlock previously.
> Hopefully mt8183-cfgcfg won't run into the issue at the resume stage
> because the GPU should have stopped rendering before the system calls
> suspend.
> 
> Fixes: 2f7b1d8b5505 ("clk: mediatek: Do a runtime PM get on controllers during probe")
> Signed-off-by: Pin-yen Lin <treapking@...omium.org>
> 
> ---

Applied to clk-fixes